From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings Date: Mon, 09 May 2016 14:55:59 +0200 Message-ID: <4320787.nfPydvIlpT@wuerfel> References: <1462797239-14765-1-git-send-email-joel@jms.id.au> <1462797239-14765-2-git-send-email-joel@jms.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1462797239-14765-2-git-send-email-joel@jms.id.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joel Stanley Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, benh@kernel.crashing.org, jk@ozlabs.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Monday 09 May 2016 22:03:58 Joel Stanley wrote: > + > +- compatible : should be "aspeed,ast2400-vic". > + > +- interrupt-controller : Identifies the node as an interrupt controller > +- #interrupt-cells : Specifies the number of cells needed to encode an > + interrupt source. The value shall be 1. > +- valid-sources : bitmask of valid irq sources > + > +Example: > + > + vic: interrupt-controller { > + compatible = "aspeed,ast2400-new-vic"; > The example doesn't match the binding regarding the compatible string, otherwise looks ok to me. Arnd