From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes
Date: Tue, 11 Jul 2023 17:59:03 +0300 [thread overview]
Message-ID: <4330df82-77a9-27ce-3f24-144718cc082e@linaro.org> (raw)
In-Reply-To: <8c3468f0-3069-95e3-e2f1-279fca78a578@linaro.org>
On 11/07/2023 14:44, Konrad Dybcio wrote:
> On 11.07.2023 08:22, Krzysztof Kozlowski wrote:
>> On 11/07/2023 08:17, Rohit Agarwal wrote:
>>>
>>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>>> Add Generic RPMh Power Domain indexes that can be used
>>>>> for all the Qualcomm SoC henceforth.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>> ---
>>>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>>> 1 file changed, 30 insertions(+)
>>>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>>
>>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>>>> new file mode 100644
>>>>> index 0000000..4da2e04
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> Filename based on compatible.
>>> This is not specific for SDX75. These are generic ones that should be
>>> used for all other targets.
>>> Konrad suggested in v1 to avoid target specific prefixes everytime and
>>> to create a new generic
>>> dt-bindings that can be reused.
>>>>> @@ -0,0 +1,30 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>> +/*
>>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>>>> + */
>>>>> +
>>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>> +
>>>>> +/* Generic RPMH Power Domain Indexes */
>>>>> +#define CX 0
>>>> These are very generic names, usually not used in global headers. Please
>>>> use some reasonable prefix.
>>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD
>>> prefix and we can go only with names like CX, etc.
>>
>> I don't think having so generic name in tree-wide header is good idea.
> Conversely, I think that it would be very clear in files including this header.
It is expected to be included into dtsi and into rpmhpd driver (only).
However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX).
Just `CX' is too short and has a sensible possibility of getting a
symbol conflict.
>
> Konrad
>> CX can mean anything.
>>
>> Best regards,
>> Krzysztof
>>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-07-11 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 5:42 [PATCH v3 0/3] Add rpmhpd support for SDX75 Rohit Agarwal
2023-07-11 5:42 ` [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes Rohit Agarwal
2023-07-11 5:52 ` Krzysztof Kozlowski
2023-07-11 6:17 ` Rohit Agarwal
2023-07-11 6:22 ` Krzysztof Kozlowski
2023-07-11 11:44 ` Konrad Dybcio
2023-07-11 14:59 ` Dmitry Baryshkov [this message]
2023-07-12 8:20 ` Rohit Agarwal
2023-07-11 6:34 ` Krzysztof Kozlowski
2023-07-11 6:35 ` Rohit Agarwal
2023-07-11 15:11 ` Dmitry Baryshkov
2023-07-12 8:24 ` Rohit Agarwal
2023-07-12 9:22 ` Konrad Dybcio
2023-07-12 9:25 ` Rohit Agarwal
2023-07-11 5:42 ` [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75 Rohit Agarwal
2023-07-11 5:53 ` Krzysztof Kozlowski
2023-07-11 5:55 ` Krzysztof Kozlowski
2023-07-11 6:20 ` Rohit Agarwal
2023-07-11 6:22 ` Krzysztof Kozlowski
2023-07-11 5:42 ` [PATCH v3 3/3] soc: qcom: rpmhpd: Add SDX75 power domains Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4330df82-77a9-27ce-3f24-144718cc082e@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).