[PATCH v3 0/3] Add rpmhpd support for SDX75

[PATCH v3 0/3] Add rpmhpd support for SDX75

[Rohit Agarwal]

Hi,

Changes in v3:
 - Removed the macros from rpmpd.h and created new generic
   bindings in patch [1/3] for rpmhpd only.
 - Corrected the versioning in this version of patch series.
 - Updated the patch series subject.
 - Updated the drivers change according to the new binding in
   patch [3/3]

Changes in v2:
 - Link to v2 series [1] (Added because of versioning mismatch).
 - Breaking the original series [2] into smaller series.
 - Added new generic bindings for rpmpd and rpmhpd keeping the
   older ones intact as removing them would break ABI [3].

This series adds the support of rpmhpd for sdx75 and also
adds the generic bindings for the PD to be used henceforth.

[1] https://lore.kernel.org/all/1688647793-20950-1-git-send-email-quic_rohiagar@quicinc.com/
[2] https://lore.kernel.org/all/1688395346-3126-1-git-send-email-quic_rohiagar@quicinc.com/
[3] https://lore.kernel.org/all/1688635218-23779-1-git-send-email-quic_rohiagar@quicinc.com/

Thanks,
Rohit.

Rohit Agarwal (3):
  dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes
  dt-bindings: power: Add compatible for sdx75
  soc: qcom: rpmhpd: Add SDX75 power domains

 .../devicetree/bindings/power/qcom,rpmpd.yaml      |  1 +
 drivers/soc/qcom/rpmhpd.c                          | 17 ++++++++++++
 include/dt-bindings/power/qcom-rpmhpd.h            | 30 ++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h

-- 
2.7.4

[PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

Add Generic RPMh Power Domain indexes that can be used
for all the Qualcomm SoC henceforth.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h

diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
new file mode 100644
index 0000000..4da2e04
--- /dev/null
+++ b/include/dt-bindings/power/qcom-rpmhpd.h
@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
+#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
+
+/* Generic RPMH Power Domain Indexes */
+#define CX               0
+#define MX               1
+#define CX_AO            2
+#define MX_AO            3
+#define GFX              4
+#define MSS              5
+#define EBI              6
+#define LCX              7
+#define LMX              8
+#define MMCX             9
+#define MMCX_AO          10
+#define MXC              11
+#define MXC_AO           12
+#define NSP              13
+#define NSP0             14
+#define NSP1             15
+#define QPHY             16
+#define DDR              17
+#define XO               18
+
+#endif
-- 
2.7.4

[PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75

[Rohit Agarwal]

Add a compatible string that can be used to list PDs for sdx75.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index f9c211a..9b03c41 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -41,6 +41,7 @@ properties:
       - qcom,sdm845-rpmhpd
       - qcom,sdx55-rpmhpd
       - qcom,sdx65-rpmhpd
+      - qcom,sdx75-rpmhpd
       - qcom,sm6115-rpmpd
       - qcom,sm6125-rpmpd
       - qcom,sm6350-rpmhpd
-- 
2.7.4

[PATCH v3 3/3] soc: qcom: rpmhpd: Add SDX75 power domains

[Rohit Agarwal]

Add power domains found in Qualcomm SDX75 SoC.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 drivers/soc/qcom/rpmhpd.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 63c35a3..0db38e8 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -15,6 +15,7 @@
 #include <soc/qcom/cmd-db.h>
 #include <soc/qcom/rpmh.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
+#include <dt-bindings/power/qcom-rpmhpd.h>
 
 #define domain_to_rpmhpd(domain) container_of(domain, struct rpmhpd, pd)
 
@@ -307,6 +308,21 @@ static const struct rpmhpd_desc sdx65_desc = {
 	.num_pds = ARRAY_SIZE(sdx65_rpmhpds),
 };
 
+/* SDX75 RPMH powerdomains */
+static struct rpmhpd *sdx75_rpmhpds[] = {
+	[CX] = &cx,
+	[CX_AO] = &cx_ao,
+	[MSS] = &mss,
+	[MX] = &mx,
+	[MX_AO] = &mx_ao,
+	[MXC] = &mxc,
+};
+
+static const struct rpmhpd_desc sdx75_desc = {
+	.rpmhpds = sdx75_rpmhpds,
+	.num_pds = ARRAY_SIZE(sdx75_rpmhpds),
+};
+
 /* SM6350 RPMH powerdomains */
 static struct rpmhpd *sm6350_rpmhpds[] = {
 	[SM6350_CX] = &cx_w_mx_parent,
@@ -545,6 +561,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
 	{ .compatible = "qcom,sdm845-rpmhpd", .data = &sdm845_desc },
 	{ .compatible = "qcom,sdx55-rpmhpd", .data = &sdx55_desc},
 	{ .compatible = "qcom,sdx65-rpmhpd", .data = &sdx65_desc},
+	{ .compatible = "qcom,sdx75-rpmhpd", .data = &sdx75_desc},
 	{ .compatible = "qcom,sm6350-rpmhpd", .data = &sm6350_desc },
 	{ .compatible = "qcom,sm8150-rpmhpd", .data = &sm8150_desc },
 	{ .compatible = "qcom,sm8250-rpmhpd", .data = &sm8250_desc },
-- 
2.7.4

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Krzysztof Kozlowski]

On 11/07/2023 07:42, Rohit Agarwal wrote:
> Add Generic RPMh Power Domain indexes that can be used
> for all the Qualcomm SoC henceforth.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
> 
> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
> new file mode 100644
> index 0000000..4da2e04
> --- /dev/null
> +++ b/include/dt-bindings/power/qcom-rpmhpd.h

Filename based on compatible.

> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +
> +/* Generic RPMH Power Domain Indexes */
> +#define CX               0

These are very generic names, usually not used in global headers. Please
use some reasonable prefix.



Best regards,
Krzysztof

Re: [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75

[Krzysztof Kozlowski]

On 11/07/2023 07:42, Rohit Agarwal wrote:
> Add a compatible string that can be used to list PDs for sdx75.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75

[Krzysztof Kozlowski]

On 11/07/2023 07:53, Krzysztof Kozlowski wrote:
> On 11/07/2023 07:42, Rohit Agarwal wrote:
>> Add a compatible string that can be used to list PDs for sdx75.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Ah, I forgot: you miss device name in subject prefixes. You do not add
here sdx75 to all power bindings, do you? This applies to all your
patches and commits.

Best regards,
Krzysztof

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
> On 11/07/2023 07:42, Rohit Agarwal wrote:
>> Add Generic RPMh Power Domain indexes that can be used
>> for all the Qualcomm SoC henceforth.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>
>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>> new file mode 100644
>> index 0000000..4da2e04
>> --- /dev/null
>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
> Filename based on compatible.
This is not specific for SDX75. These are generic ones that should be 
used for all other targets.
Konrad suggested in v1 to avoid target specific prefixes everytime and 
to create a new generic
dt-bindings that can be reused.
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>> +
>> +/* Generic RPMH Power Domain Indexes */
>> +#define CX               0
> These are very generic names, usually not used in global headers. Please
> use some reasonable prefix.
This was based on the suggestion from Konrad in v2 to drop the RPMHPD 
prefix and we can go only with names like CX, etc.

Thanks,
Rohit.
>
>
> Best regards,
> Krzysztof
>

Re: [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75

[Rohit Agarwal]

On 7/11/2023 11:25 AM, Krzysztof Kozlowski wrote:
> On 11/07/2023 07:53, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>> Add a compatible string that can be used to list PDs for sdx75.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> ---
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
> Ah, I forgot: you miss device name in subject prefixes. You do not add
> here sdx75 to all power bindings, do you? This applies to all your
> patches and commits.
Do you mean I need to update the subject as this?

dt-bindings: power: sdx75: Add compatible for sdx75

Thanks,
Rohit.

> Best regards,
> Krzysztof
>

Re: [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75

[Krzysztof Kozlowski]

On 11/07/2023 08:20, Rohit Agarwal wrote:
> 
> On 7/11/2023 11:25 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:53, Krzysztof Kozlowski wrote:
>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>> Add a compatible string that can be used to list PDs for sdx75.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>> Ah, I forgot: you miss device name in subject prefixes. You do not add
>> here sdx75 to all power bindings, do you? This applies to all your
>> patches and commits.
> Do you mean I need to update the subject as this?
> 
> dt-bindings: power: sdx75: Add compatible for sdx75

No, the device binding is qcom,rpmpd.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

Best regards,
Krzysztof

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Krzysztof Kozlowski]

On 11/07/2023 08:17, Rohit Agarwal wrote:
> 
> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>> Add Generic RPMh Power Domain indexes that can be used
>>> for all the Qualcomm SoC henceforth.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>   1 file changed, 30 insertions(+)
>>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>
>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>> new file mode 100644
>>> index 0000000..4da2e04
>>> --- /dev/null
>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>> Filename based on compatible.
> This is not specific for SDX75. These are generic ones that should be 
> used for all other targets.
> Konrad suggested in v1 to avoid target specific prefixes everytime and 
> to create a new generic
> dt-bindings that can be reused.
>>> @@ -0,0 +1,30 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>> +
>>> +/* Generic RPMH Power Domain Indexes */
>>> +#define CX               0
>> These are very generic names, usually not used in global headers. Please
>> use some reasonable prefix.
> This was based on the suggestion from Konrad in v2 to drop the RPMHPD 
> prefix and we can go only with names like CX, etc.

I don't think having so generic name in tree-wide header is good idea.
CX can mean anything.

Best regards,
Krzysztof

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Krzysztof Kozlowski]

On 11/07/2023 08:17, Rohit Agarwal wrote:
> 
> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>> Add Generic RPMh Power Domain indexes that can be used
>>> for all the Qualcomm SoC henceforth.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>   1 file changed, 30 insertions(+)
>>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>
>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>> new file mode 100644
>>> index 0000000..4da2e04
>>> --- /dev/null
>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>> Filename based on compatible.
> This is not specific for SDX75. These are generic ones that should be 
> used for all other targets.

qcom,rpmhpd.h

Best regards,
Krzysztof

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

On 7/11/2023 12:04 PM, Krzysztof Kozlowski wrote:
> On 11/07/2023 08:17, Rohit Agarwal wrote:
>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>> Add Generic RPMh Power Domain indexes that can be used
>>>> for all the Qualcomm SoC henceforth.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>>    include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>>    1 file changed, 30 insertions(+)
>>>>    create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>
>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> new file mode 100644
>>>> index 0000000..4da2e04
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>> Filename based on compatible.
>> This is not specific for SDX75. These are generic ones that should be
>> used for all other targets.
> qcom,rpmhpd.h
Ok, got it.

Thanks,
Rohit.
> Best regards,
> Krzysztof
>

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Konrad Dybcio]

On 11.07.2023 08:22, Krzysztof Kozlowski wrote:
> On 11/07/2023 08:17, Rohit Agarwal wrote:
>>
>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>> Add Generic RPMh Power Domain indexes that can be used
>>>> for all the Qualcomm SoC henceforth.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>>   1 file changed, 30 insertions(+)
>>>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>
>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> new file mode 100644
>>>> index 0000000..4da2e04
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>> Filename based on compatible.
>> This is not specific for SDX75. These are generic ones that should be 
>> used for all other targets.
>> Konrad suggested in v1 to avoid target specific prefixes everytime and 
>> to create a new generic
>> dt-bindings that can be reused.
>>>> @@ -0,0 +1,30 @@
>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>> +/*
>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>>> + */
>>>> +
>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>> +
>>>> +/* Generic RPMH Power Domain Indexes */
>>>> +#define CX               0
>>> These are very generic names, usually not used in global headers. Please
>>> use some reasonable prefix.
>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD 
>> prefix and we can go only with names like CX, etc.
> 
> I don't think having so generic name in tree-wide header is good idea.
Conversely, I think that it would be very clear in files including this header.

Konrad
> CX can mean anything.
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Dmitry Baryshkov]

On 11/07/2023 14:44, Konrad Dybcio wrote:
> On 11.07.2023 08:22, Krzysztof Kozlowski wrote:
>> On 11/07/2023 08:17, Rohit Agarwal wrote:
>>>
>>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>>> Add Generic RPMh Power Domain indexes that can be used
>>>>> for all the Qualcomm SoC henceforth.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>> ---
>>>>>    include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>>>    1 file changed, 30 insertions(+)
>>>>>    create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>>
>>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>>>> new file mode 100644
>>>>> index 0000000..4da2e04
>>>>> --- /dev/null
>>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> Filename based on compatible.
>>> This is not specific for SDX75. These are generic ones that should be
>>> used for all other targets.
>>> Konrad suggested in v1 to avoid target specific prefixes everytime and
>>> to create a new generic
>>> dt-bindings that can be reused.
>>>>> @@ -0,0 +1,30 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>> +/*
>>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>>>> + */
>>>>> +
>>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>> +
>>>>> +/* Generic RPMH Power Domain Indexes */
>>>>> +#define CX               0
>>>> These are very generic names, usually not used in global headers. Please
>>>> use some reasonable prefix.
>>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD
>>> prefix and we can go only with names like CX, etc.
>>
>> I don't think having so generic name in tree-wide header is good idea.
> Conversely, I think that it would be very clear in files including this header.

It is expected to be included into dtsi and into rpmhpd driver (only). 
However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX). 
Just `CX' is too short and has a sensible possibility of getting  a 
symbol conflict.

> 
> Konrad
>> CX can mean anything.
>>
>> Best regards,
>> Krzysztof
>>

-- 
With best wishes
Dmitry

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Dmitry Baryshkov]

On 11/07/2023 08:42, Rohit Agarwal wrote:
> Add Generic RPMh Power Domain indexes that can be used
> for all the Qualcomm SoC henceforth.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
> 
> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
> new file mode 100644
> index 0000000..4da2e04
> --- /dev/null
> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
> +
> +/* Generic RPMH Power Domain Indexes */
> +#define CX               0
> +#define MX               1
> +#define CX_AO            2
> +#define MX_AO            3
> +#define GFX              4
> +#define MSS              5
> +#define EBI              6
> +#define LCX              7
> +#define LMX              8
> +#define MMCX             9
> +#define MMCX_AO          10
> +#define MXC              11
> +#define MXC_AO           12
> +#define NSP              13
> +#define NSP0             14
> +#define NSP1             15
> +#define QPHY             16
> +#define DDR              17
> +#define XO               18

I went through the existing defines. If we adopt the order of defines 
for sm8550, we can migrate that platform and all of sm8[234]50 without 
breaking ABI. This would be a minor gain, but still something.

> +
> +#endif

-- 
With best wishes
Dmitry

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

On 7/11/2023 8:29 PM, Dmitry Baryshkov wrote:
> On 11/07/2023 14:44, Konrad Dybcio wrote:
>> On 11.07.2023 08:22, Krzysztof Kozlowski wrote:
>>> On 11/07/2023 08:17, Rohit Agarwal wrote:
>>>>
>>>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote:
>>>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>>>> Add Generic RPMh Power Domain indexes that can be used
>>>>>> for all the Qualcomm SoC henceforth.
>>>>>>
>>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>>> ---
>>>>>>    include/dt-bindings/power/qcom-rpmhpd.h | 30 
>>>>>> ++++++++++++++++++++++++++++++
>>>>>>    1 file changed, 30 insertions(+)
>>>>>>    create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>>>
>>>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h 
>>>>>> b/include/dt-bindings/power/qcom-rpmhpd.h
>>>>>> new file mode 100644
>>>>>> index 0000000..4da2e04
>>>>>> --- /dev/null
>>>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>>>> Filename based on compatible.
>>>> This is not specific for SDX75. These are generic ones that should be
>>>> used for all other targets.
>>>> Konrad suggested in v1 to avoid target specific prefixes everytime and
>>>> to create a new generic
>>>> dt-bindings that can be reused.
>>>>>> @@ -0,0 +1,30 @@
>>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>>>> +/*
>>>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All 
>>>>>> rights reserved.
>>>>>> + */
>>>>>> +
>>>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>>>> +
>>>>>> +/* Generic RPMH Power Domain Indexes */
>>>>>> +#define CX               0
>>>>> These are very generic names, usually not used in global headers. 
>>>>> Please
>>>>> use some reasonable prefix.
>>>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD
>>>> prefix and we can go only with names like CX, etc.
>>>
>>> I don't think having so generic name in tree-wide header is good idea.
>> Conversely, I think that it would be very clear in files including 
>> this header.
>
> It is expected to be included into dtsi and into rpmhpd driver (only). 
> However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX). 
> Just `CX' is too short and has a sensible possibility of getting  a 
> symbol conflict.
>
Ok, Will add them back as in v2.

Thanks,
Rohit.
>>
>> Konrad
>>> CX can mean anything.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote:
> On 11/07/2023 08:42, Rohit Agarwal wrote:
>> Add Generic RPMh Power Domain indexes that can be used
>> for all the Qualcomm SoC henceforth.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 
>> ++++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>
>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h 
>> b/include/dt-bindings/power/qcom-rpmhpd.h
>> new file mode 100644
>> index 0000000..4da2e04
>> --- /dev/null
>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights 
>> reserved.
>> + */
>> +
>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>> +
>> +/* Generic RPMH Power Domain Indexes */
>> +#define CX               0
>> +#define MX               1
>> +#define CX_AO            2
>> +#define MX_AO            3
>> +#define GFX              4
>> +#define MSS              5
>> +#define EBI              6
>> +#define LCX              7
>> +#define LMX              8
>> +#define MMCX             9
>> +#define MMCX_AO          10
>> +#define MXC              11
>> +#define MXC_AO           12
>> +#define NSP              13
>> +#define NSP0             14
>> +#define NSP1             15
>> +#define QPHY             16
>> +#define DDR              17
>> +#define XO               18
>
> I went through the existing defines. If we adopt the order of defines 
> for sm8550, we can migrate that platform and all of sm8[234]50 without 
> breaking ABI. This would be a minor gain, but still something.
>
Actually, I added them in the sequence based on the frequency with which 
they occur in the driver, so that there are less NULL entries created 
for any target additions. Shouldnt we keep it this way and ignore for 
previous targets then?

Thanks,
Rohit.
>> +
>> +#endif
>

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Konrad Dybcio]

On 12.07.2023 10:24, Rohit Agarwal wrote:
> 
> On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote:
>> On 11/07/2023 08:42, Rohit Agarwal wrote:
>>> Add Generic RPMh Power Domain indexes that can be used
>>> for all the Qualcomm SoC henceforth.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>   include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>   1 file changed, 30 insertions(+)
>>>   create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>
>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>> new file mode 100644
>>> index 0000000..4da2e04
>>> --- /dev/null
>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>> @@ -0,0 +1,30 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>> +
>>> +/* Generic RPMH Power Domain Indexes */
>>> +#define CX               0
>>> +#define MX               1
>>> +#define CX_AO            2
>>> +#define MX_AO            3
>>> +#define GFX              4
>>> +#define MSS              5
>>> +#define EBI              6
>>> +#define LCX              7
>>> +#define LMX              8
>>> +#define MMCX             9
>>> +#define MMCX_AO          10
>>> +#define MXC              11
>>> +#define MXC_AO           12
>>> +#define NSP              13
>>> +#define NSP0             14
>>> +#define NSP1             15
>>> +#define QPHY             16
>>> +#define DDR              17
>>> +#define XO               18
>>
>> I went through the existing defines. If we adopt the order of defines for sm8550, we can migrate that platform and all of sm8[234]50 without breaking ABI. This would be a minor gain, but still something.
>>
> Actually, I added them in the sequence based on the frequency with which they occur in the driver, so that there are less NULL entries created for any target additions. Shouldnt we keep it this way and ignore for previous targets then?
Don't bother yourself with this, we've already dragged you through
some bindings mess ;)

Dmitry just noticed that a happy coincidence occured and we could
swap out SM8[234]_50 indices with these ones and they would still
match. It'd be a separate patch though.

Konrad
> 
> Thanks,
> Rohit.
>>> +
>>> +#endif
>>

Re: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes

[Rohit Agarwal]

On 7/12/2023 2:52 PM, Konrad Dybcio wrote:
> On 12.07.2023 10:24, Rohit Agarwal wrote:
>> On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote:
>>> On 11/07/2023 08:42, Rohit Agarwal wrote:
>>>> Add Generic RPMh Power Domain indexes that can be used
>>>> for all the Qualcomm SoC henceforth.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>>    include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
>>>>    1 file changed, 30 insertions(+)
>>>>    create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
>>>>
>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> new file mode 100644
>>>> index 0000000..4da2e04
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h
>>>> @@ -0,0 +1,30 @@
>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>>> +/*
>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>>> + */
>>>> +
>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H
>>>> +
>>>> +/* Generic RPMH Power Domain Indexes */
>>>> +#define CX               0
>>>> +#define MX               1
>>>> +#define CX_AO            2
>>>> +#define MX_AO            3
>>>> +#define GFX              4
>>>> +#define MSS              5
>>>> +#define EBI              6
>>>> +#define LCX              7
>>>> +#define LMX              8
>>>> +#define MMCX             9
>>>> +#define MMCX_AO          10
>>>> +#define MXC              11
>>>> +#define MXC_AO           12
>>>> +#define NSP              13
>>>> +#define NSP0             14
>>>> +#define NSP1             15
>>>> +#define QPHY             16
>>>> +#define DDR              17
>>>> +#define XO               18
>>> I went through the existing defines. If we adopt the order of defines for sm8550, we can migrate that platform and all of sm8[234]50 without breaking ABI. This would be a minor gain, but still something.
>>>
>> Actually, I added them in the sequence based on the frequency with which they occur in the driver, so that there are less NULL entries created for any target additions. Shouldnt we keep it this way and ignore for previous targets then?
> Don't bother yourself with this, we've already dragged you through
> some bindings mess ;)
>
> Dmitry just noticed that a happy coincidence occured and we could
> swap out SM8[234]_50 indices with these ones and they would still
> match. It'd be a separate patch though.
Yes sure. Will make a separate patch updating entries for these targets.

Thanks,
Rohit.
> Konrad
>> Thanks,
>> Rohit.
>>>> +
>>>> +#endif