Re: [PATCH v5 2/7] mailbox: arm_mhu: add driver for ARM MHU controller

Russell King - ARM Linux
2015-02-03T14:46:11Z

On Tue, Feb 03, 2015 at 08:09:34PM +0530, Jassi Brar wrote:
> On 3 February 2015 at 18:02, Russell King - ARM Linux
> <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> wrote:
> > On Tue, Feb 03, 2015 at 05:29:23PM +0800, Vincent Yang wrote:
> >> +static int mhu_send_data(struct mbox_chan *chan, void *data)
> >> +{
> >> + struct mhu_link *mlink = chan->con_priv;
> >> +
> >> + pr_debug("%s:%d\n", __func__, __LINE__);
> >> + if (!mhu_last_tx_done(chan)) {
> >> + dev_err(chan->mbox->dev, "Last TX(%d) pending!\n", mlink->irq);
> >> + return -EBUSY;
> >> + }
> >> +
> >> + writel_relaxed((u32)data, mlink->tx_reg + INTR_SET_OFS);
> >
> > Doesn't that cause a GCC warning?
> >
> I don't see any, but I'll drop the cast.

A cast is probably needed. You're right that GCC no longer warns about
this - I'm pretty sure it used to complain about casting pointers to
ints, and we used to need to cast to "unsigned long" first.

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.