From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc8280xp: Don't keep display AHB clocks always-on
Date: Sat, 30 Sep 2023 18:44:47 +0200 [thread overview]
Message-ID: <43473e04-ac33-179e-4343-e5c78eef3faf@linaro.org> (raw)
In-Reply-To: <ZRfsvAJIdlmOWjf2@hovoldconsulting.com>
On 9/30/23 11:39, Johan Hovold wrote:
> On Fri, Sep 29, 2023 at 03:38:53PM +0200, Konrad Dybcio wrote:
>> These clocks are consumed by the dispcc[01] clock controllers, so there's
>> no reason to keep them on from gcc probe. Remove that hack.
>
> Eh, how did you test this patch?
Oehh you're right, I didn't notice that I still had clk_ignore_unused :/
>
> The GCC_DISP_AHB_CLK clocks are not modelled by the clock driver
> currently so nothing is guaranteeing them to be enabled if we were to
> apply this patch. They just happen to be left on by the bootloader on
> some machines currently (well at least one of them is on one machine).
What fooled me is that despite not being modeled by the clock driver, it
is defined in bindings and referenced in the device tree.
Another thing I'll fix up!
> So this series is broken and should not be applied.
Agreed, I'll revisit this tonight or next week.
>
> NAK.
>
> Also, please CC me on sc8280xp and X13s related patches.
Omitting you was not intentional, sorry!
Konrad
next prev parent reply other threads:[~2023-09-30 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 13:38 [PATCH 0/2] 8280 display ahb clk fixes Konrad Dybcio
2023-09-29 13:38 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: Use the correct AHB clock for DISPSS1 Konrad Dybcio
2023-09-29 13:38 ` [PATCH 2/2] clk: qcom: gcc-sc8280xp: Don't keep display AHB clocks always-on Konrad Dybcio
2023-09-30 9:39 ` Johan Hovold
2023-09-30 16:44 ` Konrad Dybcio [this message]
2023-10-02 8:34 ` Johan Hovold
2023-10-02 9:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43473e04-ac33-179e-4343-e5c78eef3faf@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).