From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
Shawn Lin <shawn.lin@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB
Date: Wed, 11 May 2016 16:51:58 +0200 [thread overview]
Message-ID: <4355979.JCGxOmTVBW@phil> (raw)
In-Reply-To: <1462924975-69072-2-git-send-email-briannorris@chromium.org>
Hi Brian,
Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris:
> The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring,
> though it's still not merged.
The commit message should describe the actual change not the volatile
environment surrounding it :-) .
When I apply this patch the property-binding will have made it into a
maintainer-tree so is not valid anymore then. That is more material for the
"comment-section" below the "---"
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index
> 1a3eb1482050..ccfd2bcf02e1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
> @@ -89,6 +89,18 @@
> status = "okay";
> };
>
> +&emmc_phy {
> + status = "okay";
> +};
> +
> +&sdhci {
> + bus-width = <8>;
> + mmc-hs400-1_8v;
> + non-removable;
> + mmc-hs400-enhanced-strobe;
alphabetic ordering of properties please
> + status = "okay";
> +};
> +
> &uart2 {
> status = "okay";
> };
next prev parent reply other threads:[~2016-05-11 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 0:02 [PATCH 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris
2016-05-11 0:02 ` [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris
[not found] ` <1462924975-69072-2-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-05-11 0:59 ` Shawn Lin
[not found] ` <d8dc5609-3cf6-80ce-462b-d46f0ea6dcff-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-11 1:19 ` Brian Norris
2016-05-11 14:51 ` Heiko Stuebner [this message]
2016-05-11 22:32 ` Brian Norris
[not found] ` <20160511223233.GB65449-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-05-11 22:36 ` Heiko Stuebner
2016-05-11 1:17 ` [PATCH 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Shawn Lin
2016-05-11 22:31 ` Brian Norris
[not found] ` <3e257ce2-056a-592a-9481-970da1fe0627-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-12 22:22 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4355979.JCGxOmTVBW@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).