devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Robert Marko" <robimarko@gmail.com>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 1/3] dt-bindings: net: wireless: qcom,ath11k: allow describing radios
Date: Wed, 19 Apr 2023 22:05:04 +0200	[thread overview]
Message-ID: <4366b07b-a144-5e7f-ec41-1f58491b36f5@linaro.org> (raw)
In-Reply-To: <20230418093822.24005-1-zajec5@gmail.com>

On 18/04/2023 11:38, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Qualcomm ath11k chipsets can have up to 3 radios. Each radio may need to
> be additionally described by including its MAC or available frequency
> ranges.

The binding looks fine, but I wonder what is the radio here? It feels
like one antenna, e.g. 2.4 or 5 GHz, but you added $ref to
ieee80211.yaml which is used for entire device. What is the "radio" here?

> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Fix dt_binding_check (add address + size cells & reg)
> ---

Best regards,
Krzysztof


      parent reply	other threads:[~2023-04-19 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  9:38 [PATCH V2 1/3] dt-bindings: net: wireless: qcom,ath11k: allow describing radios Rafał Miłecki
2023-04-18  9:38 ` [PATCH V2 2/3] wifi: ath11k: look for DT node for each radio Rafał Miłecki
2023-04-18  9:38 ` [PATCH V2 3/3] wifi: ath11k: support reading radio MAC from DT Rafał Miłecki
2023-04-19 20:05 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4366b07b-a144-5e7f-ec41-1f58491b36f5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=ath11k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).