From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92726C433E2 for ; Sat, 18 Jul 2020 00:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FCE820759 for ; Sat, 18 Jul 2020 00:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="YVGERfFC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbgGRAlF (ORCPT ); Fri, 17 Jul 2020 20:41:05 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:24384 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728276AbgGRAlE (ORCPT ); Fri, 17 Jul 2020 20:41:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595032864; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=iNKJj+TLzkBnI4NSsc5gA6qzfp4yaENwEEBOKVBFHZM=; b=YVGERfFCTvjK5Kh6ZfPvrAEEOAORfxq7l4yOJIE7v+k8Si6r5U7/A01WW8peViKkVtLlHDUV K+l23ypb4YSQ6MuKajuVyktYT0haYnrxHIeLEc78pwoL+XIz14F1QFv39qHnDqo35TSvO8Rm MUhSesU26sUPDqysXYHf+LXxh2Y= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 5f12451fe3bee125108f0b52 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 18 Jul 2020 00:41:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C3AFEC433CB; Sat, 18 Jul 2020 00:41:02 +0000 (UTC) Received: from [192.168.1.117] (ip70-179-20-127.sd.sd.cox.net [70.179.20.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mdtipton) by smtp.codeaurora.org (Postfix) with ESMTPSA id BF392C433C9; Sat, 18 Jul 2020 00:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BF392C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=mdtipton@codeaurora.org Subject: Re: [PATCH v2 2/6] dt-bindings: interconnect: Add property to set BCM TCS wait behavior To: Rob Herring Cc: georgi.djakov@linaro.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200710015652.19206-1-mdtipton@codeaurora.org> <20200710015652.19206-3-mdtipton@codeaurora.org> <20200710163119.GA2753833@bogus> From: Mike Tipton Message-ID: <43a0638a-ea3d-eb96-16d0-524148f86bc3@codeaurora.org> Date: Fri, 17 Jul 2020 17:41:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200710163119.GA2753833@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/10/2020 9:31 AM, Rob Herring wrote: > On Thu, Jul 09, 2020 at 06:56:48PM -0700, Mike Tipton wrote: >> Add "qcom,tcs-wait" property to set which TCS should wait for completion >> when triggering. >> >> Signed-off-by: Mike Tipton >> --- >> .../bindings/interconnect/qcom,bcm-voter.yaml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml >> index 5971fc1df08d..f0c3d6b01831 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml >> @@ -21,6 +21,16 @@ properties: >> enum: >> - qcom,bcm-voter >> >> + qcom,tcs-wait: >> + description: | >> + Optional mask of which TCSs (Triggered Command Sets) wait for completion >> + upon triggering. In most cases, it's necessary to wait in both the AMC >> + and WAKE sets to ensure resources are available before use. If a specific >> + RSC and its use cases can ensure sufficient delay by other means, then >> + this can be overridden to reduce latencies. > > I have no idea what any of this means to provide any meaningful comment. > >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + default: QCOM_ICC_TAG_ACTIVE_ONLY > > Can't use defines here. What's the recommended alternative? The meaning isn't obvious as a raw number (3). We expect the defines to be used in the dt files themselves (see example below). Is this just a restriction for the `default` documentation specifically? I could just mention the default behavior in the description I suppose, but that seems to defeat the purpose of having a separate `default` key. > >> + >> required: >> - compatible >> >> @@ -39,7 +49,10 @@ examples: >> # as defined in Documentation/devicetree/bindings/soc/qcom/rpmh-rsc.txt >> - | >> >> + #include >> + >> disp_bcm_voter: bcm_voter { >> compatible = "qcom,bcm-voter"; >> + qcom,tcs-wait = ; >> }; >> ... >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >>