From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D5441DDEC for ; Fri, 25 Sep 2026 20:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790368137; cv=none; b=NkkbiqFD3qq/7b8ONN/pLaerQqQbRm8LovXJkx1DO0gmft/vbvw77slTzk72vWCOkb6H5pLocWvw9pZBSJMKIOWFLY0XRTRCmSgtS13gPdyPlzpd8OnShs7AAp9McJGteutLHrJWzluvivyhQnoKMyq3857jrqQRYN3apuRzDFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790368137; c=relaxed/simple; bh=5fShnnoriXDSFjno6iUPpU5yLB7IRZwuhDOkWk3b+s0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MkyJ1hGFwNvggBxgxhSgCCxskLkTM3LMo6ijUMaBweg18hmVl87L3ikinv6HH9iDFSRUDRPrWp9u+/6o8u3wOHAGuy5qoVmb5wkBQwXdt4MuVoHnHZBMobfJk2j8XGEECYxxvmVM0z/XjOYE2hsFCzTC1Z4JgLfhwo+mG/NFYwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SByuu/Xl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yz5Adm8a; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SByuu/Xl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yz5Adm8a" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68PIoF5A2889826 for ; Fri, 25 Sep 2026 20:28:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oSB1zv8lUGPCqbfvSMMMcjcivsocAtHZ2FPmhXQguZ8=; b=SByuu/XlXUq4LIC0 kpbi3Xls2siw8g50yiMRNoAcQtdLo10qPuFYYPNkQc9jb5N1E16Ck7mN3+QIE2CM gDWvR+XxL9JlmuJ+I2HSWDXfIwWIPj/2snxyCS/CMhuMNXwrM94ZK2sH1g4KKRPn X44pubMD8YWL7Ucy4gzzxKwbVlKWefn9bQtZ1Z0frnVgAZ1UV63bia/A+y5f4wT4 JQqd2J2hVDmNOqwGjIpDm5EzgUzv56yuYBZ4xvvsqFJVEl31MyXH0o6GynlSy5MG SPmoEHijcWrj13J7mVc3IWUhIW64xTg8Urb2aeSldJFjN9unQ3TtxIOnHaXzqx99 shbYXA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gwwjc8nu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 25 Sep 2026 20:28:55 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-934956beec8so273025485a.0 for ; Fri, 25 Sep 2026 13:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790368134; x=1790972934; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oSB1zv8lUGPCqbfvSMMMcjcivsocAtHZ2FPmhXQguZ8=; b=Yz5Adm8aG5P0Z8SDxt6n8hVAlboW3LONN4nxbFZxQikMf7a+LHZE2orW/JNWinLSne KGiD9PRS4+7h/K6Hoxa9uE3dLo21v7JKby08uoIqV4F+ZpKdytiZF33fjsHOd3IvwASI Hidn9WciWBls2WOLOU8Ch1lz3qivcb8Rd/P2RDwhv+hDPBYnYIKgoJ2O6DsGGzfhGxJb dUup8mk+ALZ1ObluoGoes/1M89Iziyfvgu4etyooYJgZFE9k1cfn6GPBIW2jktExviml WDxLHrGbLbdoiJRTrVnecBxFJD8jieeBidNSuqoIb5/+WxUG3qhMnBNPDaUKsGwCwYVn 24RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790368134; x=1790972934; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oSB1zv8lUGPCqbfvSMMMcjcivsocAtHZ2FPmhXQguZ8=; b=2E1BO61Iymo1x1OllShdB1OZoWJXA+JFn/S9EAddfbmpVpOMhPk0krUsV2RaDbLcT4 h/T2yf6CDBLWzPQGT862zzRxEIS7vw4r5Io4ZzqQUT5Y5rGr4zGH5IiVpCf7vzgYmonP VRdco8xI1ECwCUgg2ed2sx1+eeKL8yN11z47DnO+vg64d/wwbih4qgDFClgCCQxTelto ZX5qi/YSe2cl9ycqrlVsKMSPbSziCUWpfDA7vjOu3mayJ4Lh+Il7LnzoucJ8ekLw/Nng +eozGaTGIbhajajJuj+q2vDbscUk6QhGEouARjXOGWnl52XUh4DNwtKKrxTP73tECV3X /gOw== X-Forwarded-Encrypted: i=1; AKwUvBxZXHdU2uJCDon7ohFNZBJjCkdF5NWd5M0UrijCs2tRVRuE7O6j3aHJl6n+1INjTCUrJoAI0INpkkyD@vger.kernel.org X-Gm-Message-State: AFuF++l0pzsPYIwigm7iwBjVZMoG6heoGFlr1/NMM10qbK55qsnlLZgF lPi14M8AsDG+qrmrUDV4sbsZuveItpiTE9OCGkERcATJlDrgkTlD8oK1iYwO7Ov1aY1hb+k57fr 6bOLfOi3tNTpzvGqy7GULN18jSd6hsTWDBJkAGYvW4fbfZ9wtBSwU86O5opdBBSQe X-Gm-Gg: AYBFou3kYX6j0fMRjUWXDcAoTuFNRjV6SuGLkSWkW4f9JY4qyVA67GZg7PPm2iZr+bA hmxwS5PDwXTjbr0yOL6p6p85LEzQkhurH7qMtUr3fQDrFaNDH4VDaTZbuBwGb6aF0L+LvaZUkyw BwyBU/OKuiiYT37+MEvKnAb0TFhxEuaYC2CC2jIc0ODd7+AiS11E+yl3dkyzYgvHqCuB6PRX/aQ O8SHOgNQrmn0tDlO5av2MfWqSKw54CrsOKFi+CfYMRQ0j6/MbLdtKfumi2sMtWIUCySVIa8fAor wuIka2uYajf5ndxWLfyB2G6Tv14mpGf3RzZg1jjcXBV08k1wy2eBj4/Yw9TIeT8fvMdFl3Ecr1Q YW2xgY2s4SfbhIcuk+2LRY4P4ag== X-Received: by 2002:a05:620a:4692:b0:939:c1d4:e2e1 with SMTP id af79cd13be357-93c43be3c72mr685814185a.25.1790368134201; Fri, 25 Sep 2026 13:28:54 -0700 (PDT) X-Received: by 2002:a05:620a:4692:b0:939:c1d4:e2e1 with SMTP id af79cd13be357-93c43be3c72mr685809385a.25.1790368133755; Fri, 25 Sep 2026 13:28:53 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49fe5dfa6a7sm275845885e9.12.2026.09.25.13.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2026 13:28:53 -0700 (PDT) Message-ID: <43a45cca-e214-4f0b-a026-14da8b33b3f8@oss.qualcomm.com> Date: Fri, 25 Sep 2026 21:28:51 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 7/7] ASoC: codecs: add Qualcomm Tambora (WCD9378) SDCA codec To: Mark Brown Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bard Liao , Pierre-Louis Bossart , Charles Keepax , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Maciej Strozek , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20260925161049.758913-1-srinivas.kandagatla@oss.qualcomm.com> <20260925161049.758913-8-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDA4MSBTYWx0ZWRfXxDkxiOyjUoJ0 rCPkdqixtXLEQWd5GSN8gRyrFS1EqNBx4GaVJdLNMcBH3RP28CCdi2NayyBVr2zauteS4xEugX6 uDp52nieTEIwDSYlQ0BKxRhLFAg2l/w= X-Authority-Analysis: v=2.4 cv=dZwVTnXe c=1 sm=1 tr=0 ts=6ab6d987 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=naP4cl9ZAa0KIA1VvjkA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDA4MSBTYWx0ZWRfX+Qiq2GMI73kH t3FHfp11wk22acXAyWx6z3kLghDPB/GmVANOTCwMcXW3YfcyVVKuHMnO8GaLEgmIz+6hUw3PLBY e3z/ls7NR4dy79VvcDxTddWLyLpc0/FPeQreO+BjDEEyLTghxgUHnLHyAnjpQYSAHfHKU98t2Fp raBeon/X++Kk8XAciW1r4fWDzn7x6/VQKBl16nwCeY8UKv2IuXRN8eqj9ocTfzpaiNaHZN2VZ4Q iHjOSZt7lPdAHFhLZg4rnBhIzNWGBvubt7GqrbLzba9ImAbOj4GPSOYcY9hE4aB+wPpAfQL0vUQ WIKQ/xxoVEPgQEokPpHiwhCIKdeJNiB5QVZV/AnuIr1hfHp1ydr3mVMYSjGoD1tu96r9Pc1egkV sb/Rv68WPQVm32q1z/7V61TBU5AnNQ2R09zg/hosOUH+dpaYMRSamm3vvVPewtNRcawfAueEScP qfADi2DCT7T5lYoJCSw== X-Proofpoint-GUID: PkhZnVy6utMQ_RZtHJLXr4sR7m_yOKZE X-Proofpoint-ORIG-GUID: PkhZnVy6utMQ_RZtHJLXr4sR7m_yOKZE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250081 On 9/25/26 6:31 PM, Mark Brown wrote: > On Fri, Sep 25, 2026 at 05:10:48PM +0100, Srinivas Kandagatla wrote: >> Add support for the Qualcomm Tambora (WCD9378) headset codec in SDCA >> mode over SoundWire. On ARM/DT platforms without ACPI/DisCo firmware >> the SDCA topology and SoundWire port properties are supplied as static >> data through the codec driver. > >> +static struct sdca_control entity_fu6_controls[] = { >> + { .sel = SDCA_CTL_FU_MUTE, .mode = SDCA_ACCESS_MODE_DUAL, >> + .layers = SDCA_ACCESS_LAYER_USER, .cn_list = 0x6, .nbits = 1, >> + .type = SDCA_CTL_DATATYPE_ONEBIT, >> + .interrupt_position = SDCA_NO_INTERRUPT, >> + .has_reset = true, .reset = 1, >> + .label = SDCA_CTL_MUTE_NAME }, >> + { .sel = SDCA_CTL_FU_CHANNEL_VOLUME, .mode = SDCA_ACCESS_MODE_DUAL, >> + .layers = SDCA_ACCESS_LAYER_USER, .cn_list = 0x6, .nbits = 16, >> + .type = SDCA_CTL_DATATYPE_Q7P8DB, >> + .range = { .cols = SDCA_VOLUME_LINEAR_NCOLS, .rows = 1, >> + .data = range_fu6_vol_data }, >> + .interrupt_position = SDCA_NO_INTERRUPT, >> + .label = SDCA_CTL_CHANNEL_VOLUME_NAME }, >> +}; > > Why do only these have nbits and type? These are the the controls exposed to user as mute and Volume. Looks like asoc_sdca.c does not use type and derive nbits, it directly uses control->nbits. We can add the conversion in framework, if that is something preferable. --srini