From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8818925F7A9; Tue, 14 Jul 2026 13:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035078; cv=none; b=t8eSntR96eb01YqNx99JGf7St7SfPGcEq5b5dv8OI4SvB/zgO87A23BttSAO36HsOaQfNzsPRf3PR5pO5B84YaEE0LLV2FDfuiqUFpxEORhSx8RXHq2rMhPCehaNTSrg+usaCvMxkJRSXQWEzN3uZiOKomlrYoeYCRaS6OSGU2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035078; c=relaxed/simple; bh=uyHTyo6BlQ8apSEosH8aRF5IYuQJO2rsniW4LEhh/PA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qe58k0dNyg962eABT6FRMP+UE+SDuETv0Fv1O8uIY70B3Bz3C4GOZ4Ho1w7zL45elA5DxXAVkzP/bwECpKAsuQW3Qtn43ZKVDgBTtDl/bWj6ULsS1i/Ll0WUadsS0YaF2TlreEUHmgEPI9nYH8bCfMfAFcnc+wH+37cEGDQ6g5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=a6Bkgyoh; arc=none smtp.client-ip=80.241.56.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="a6Bkgyoh" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4h00Gl6g31zMlV7; Tue, 14 Jul 2026 15:17:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1784035071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/cRu//uWOT+qbh6qti9TRa8/+CwFICDDK98F8HF74U=; b=a6BkgyohfmFI+SrqxlZSKaV8Mxro64qxCsTaKQUj57vVL1YP83+ZmREJX+WB8HYThSsolS fzdGccDFmlRU021CFKT+MLG3V5KkSvexSHlDHUNn8dMFXIO9tKqUVjzuLccjIZPSPZZ1gT UitCI1+6i4QFVrOhd+Y26YV92pmFlqNsaWO9Tjp9Gjkud5SegyW/7ASV9X7Nz+ilqNgOUw uVeCcB4bUeMqAC1/IxZADk2PgVQEepEp1Pt1hN9WPWbq9lnLEq2US+FINcmGYTcWBi8GP8 Zu4YnuDP/2MPORP2mYESX/Kevt630h1jrXBgd6OKFgpOtZUrn9lWXEn7pd+HPw== Message-ID: <43b0883c-8ade-4129-8fe3-bd6fcb191ea5@mailbox.org> Date: Tue, 14 Jul 2026 15:17:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro To: Bjorn Helgaas Cc: Marc Zyngier , linux-pci@vger.kernel.org, kernel test robot , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Catalin Marinas , Conor Dooley , Geert Uytterhoeven , Krzysztof Kozlowski , Lorenzo Pieralisi , Manivannan Sadhasivam , Rob Herring , Yoshihiro Shimoda , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260714110041.GA1349622@bhelgaas> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260714110041.GA1349622@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 32a8528cd2be18f19ff X-MBO-RS-META: 4qmkcnquwqej65t44z98iiowifkh7d94 On 7/14/26 1:00 PM, Bjorn Helgaas wrote: > On Mon, Jul 13, 2026 at 08:05:38PM +0200, Marek Vasut wrote: >> On 7/13/26 7:54 PM, Bjorn Helgaas wrote: >>> On Fri, Jul 10, 2026 at 03:35:10PM +0200, Marek Vasut wrote: >>>> On 7/10/26 10:30 AM, Marc Zyngier wrote: >>>>> On Thu, 09 Jul 2026 21:10:03 +0100, >>>>> Marek Vasut wrote: >>>>>> >>>>>> Instead of pulling in the whole linux/irqchip/arm-gic-v3.h , >>>>>> copy the one GITS_TRANSLATER register offset macro directly into >>>>>> the driver. This repairs the ability to build the driver on >>>>>> non-ARM non-GIC targets the way it was possible until now, which >>>>>> retains good build test coverage. >>>> ... >>> >>>> So in the end, it is either this patch or limit the build to >>>> arm/arm64 . At least this patch still allows building this driver >>>> with more compilers on the various build bots, so I would opt for >>>> this patch here. >>> >>> I like the build coverage, but duplicating the #define doesn't really >>> seem good to me. It makes readability worse because cscope/tags now >>> sees two definitions without an obvious reason. >> >> I can rename the macro, or ... sigh ... I can reduce the driver to build >> only on ARM/ARM64. Which one do you prefer ? > > I think a dependency on ARM/ARM64 is preferable. I will send a V2 shortly.