From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14FD1C6FD1D for ; Fri, 7 Apr 2023 18:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjDGSLd (ORCPT ); Fri, 7 Apr 2023 14:11:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbjDGSLb (ORCPT ); Fri, 7 Apr 2023 14:11:31 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B41CBAF2C for ; Fri, 7 Apr 2023 11:11:29 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-4fa3c484814so2107575a12.3 for ; Fri, 07 Apr 2023 11:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680891088; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L+XwHH+NxH3fpDTzT7U2Uejz40Vg3/GuvV21vLfzLyA=; b=mkSF57qv7GXr0i6rVvc5d21h96Tj8SqUcR64xPYNrobd+PQ7P6B0Zt3vCo/pDNt6sj +qxLslDoBW1QlLB5DBUtbV7WXVcuQF+wmouHnEDpCujvPmtd8ImsjYTsgGKVemzI99wU JzRJnG9LldtJyfbrD68/U+qOSot3OZywvaL9R9Z1N2T5+zjL5ZNn1rzwUzq5SEiheiZ1 4/Zv7GFSNIfAJ6NbHOWw/HH9x0bVBtG2oCd/8qctgs0r801T+iJVqdS3EcsRYI40uyIC qqQtiXU8i0Vut4VcWtLxyFGEdyIotlef6orWDCPU4JbhCgIGHewRJotSj5A5v1p2IW01 PdrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680891088; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L+XwHH+NxH3fpDTzT7U2Uejz40Vg3/GuvV21vLfzLyA=; b=s2MwsUSFPP/AWMec+yWap29zMPR2jCTwhxthNxLiyTQupwSdbjpk5xB4aNo4AZsozG 1VlhuC4zBc8zmu3D/mPTpyeatvkI2oWjpeeHPebV/JV661Dde4vZcPbDFB8C46C+t3wI +tFao3j1SbrKKZsqvTbGopdqmjSvsjnwBC8Ep+hyZ3oAzCPLGodC3a4aIsjw2Pjv/fFn IVDZFkl1CVUwuhnN8O6MSFVkYVUXZBdgDT4NLE55PUer8m0hIctii0YX8gHSizcsJ84q +dqHv/Y9LV2CEWWbLuz2eXq6PRZGONaXlT4TXqFTrCf5B6z/HGvIhnTqAerworUINP03 AwdQ== X-Gm-Message-State: AAQBX9fOI2CIet0fd1zClcneVYREs9EdJLtJJTNyPvHRm1uNMVP9Wvx8 LVpknqwrSTcOC9A2Os4CN7gCwQ== X-Google-Smtp-Source: AKy350YA4WOMGlUud0T2KIJv6phMSse28tyWV3pz9UJmgbHa/WEwOfeYZ8OM4J3oJ5P98WpBIqBrvw== X-Received: by 2002:a50:fb87:0:b0:501:d532:d84e with SMTP id e7-20020a50fb87000000b00501d532d84emr2779887edq.39.1680891087495; Fri, 07 Apr 2023 11:11:27 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:b20f:8824:c926:8299? ([2a02:810d:15c0:828:b20f:8824:c926:8299]) by smtp.gmail.com with ESMTPSA id m20-20020a509994000000b0050470aa444fsm1700323edb.51.2023.04.07.11.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 11:11:27 -0700 (PDT) Message-ID: <43b74b3f-e607-ba55-a5fa-326fb4b5519d@linaro.org> Date: Fri, 7 Apr 2023 20:11:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 12/14] arm64: dts: qcom: sc7180: Fix trogdor qspi pin config Content-Language: en-US To: Douglas Anderson , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Mark Brown , Linus Walleij Cc: Matthias Kaehlcke , Konrad Dybcio , linux-gpio@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, Andy Gross , linux-kernel@vger.kernel.org References: <20230323173019.3706069-1-dianders@chromium.org> <20230323102605.12.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid> From: Krzysztof Kozlowski In-Reply-To: <20230323102605.12.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/03/2023 18:30, Douglas Anderson wrote: > In commit 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial > trogdor and lazor dt") we specified the pull settings on the boot SPI > (the qspi) data lines as pullups to "park" the lines. This seemed like > the right thing to do, but I never really probed the lines to confirm. > > &qup_i2c2_default { > @@ -1336,6 +1340,22 @@ p_sensor_int_l: p-sensor-int-l-state { > bias-disable; > }; > > + qspi_sleep: qspi-sleep-state { > + pins = "gpio63", "gpio64", "gpio65", "gpio68"; > + > + /* > + * When we're not actively transferring we want pins as GPIOs > + * with output disabled so that the quad SPI IP block stops > + * driving them. We rely on the normal pulls configured in > + * the active state and don't redefine them here. Also note > + * that we don't need the reverse (output-enable) in the > + * normal mode since the "output-enable" only matters for > + * GPIO function. > + */ > + function = "gpio"; > + output-disable; Doug, I acked some of your patches, but I assumed you tested all this. It turns out you never run dtbs_check on the patches you sent. Best regards, Krzysztof