Re: [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 21/04/2022 10:04, Jacky Huang wrote:
> 
> 
> On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote:
>> On 21/04/2022 08:39, Jacky Huang wrote:
>>>
>>> On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote:
>>>> On 18/04/2022 10:27, Jacky Huang wrote:
>>>>> +properties:
>>>>> +  $nodename:
>>>>> +    const: '/'
>>>>> +  compatible:
>>>>> +    items:
>>>>> +      - enum:
>>>>> +          - nuvoton,ma35d1
>>>>> +          - nuvoton,ma35d1-evb
>>>>> +          - nuvoton,ma35d1-iot
>>>>> +          - nuvoton,ma35d1-som512
>>>>> +          - nuvoton,ma35d1-som1g
>>>> This does not match your DTS and does not look reasonable (SoC
>>>> compatible should not be part of this enum). Check some other board
>>>> bindings for examples.
>>>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>> I would like to modify it as follows:
>>>
>>> description: |
>>>     Boards with an ARMv8 based Nuvoton SoC shall have the following
>>>     properties.
>>>
>>> properties:
>>>     $nodename:
>>>       const: '/'
>>>     compatible:
>>>       oneOf:
>>>
>>>         - description: MA35D1 evaluation board
>>>           items:
>>>             - const: nuvoton,ma35d1-evb
>>>             - const: nuvoton,ma35d1
>>>
>>>         - description: MA35D1 IoT board
>>>           items:
>>>             - const: nuvoton,ma35d1-iot
>> Instead just enum with all board compatibles.
> 
> How about to modify it as the follows:
> 
>    compatible:
>      oneOf:
> 
>        - description: MA35D1 evaluation board
>          items:
>            - enum:
>                - nuvoton,ma35d1-evb
>            - const: nuvoton,ma35d1
> 
>        - description: MA35D1 IoT board
>          items:
>            - enum:
>                - nuvoton,ma35d1-iot
>            - const: nuvoton,ma35d1
> 
>        - description: MA35D1 SOM board
>          items:
>            - enum:
>                - nuvoton,ma35d1-som512
>                - nuvoton,ma35d1-som1g
>            - const: nuvoton,ma35d1
> 

It's still almost the same. All boards together. You can add a comment
next to the compatible if you want some user-friendly name.


Best regards,
Krzysztof