From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A40C433F5 for ; Thu, 21 Apr 2022 08:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386419AbiDUIIV (ORCPT ); Thu, 21 Apr 2022 04:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386416AbiDUIIU (ORCPT ); Thu, 21 Apr 2022 04:08:20 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC96B1B7A0 for ; Thu, 21 Apr 2022 01:05:30 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id p18so283289edr.7 for ; Thu, 21 Apr 2022 01:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=q1EKn9j2FtU/5NboQOODHWM3vZN+UjF82zhvbN8nb9k=; b=R6lSh2UFKaO74B3eWJIkVab0BloB6Dhobt1+TrxUz2TUSrZ8aLO3F9hQefyTcjUhlj ckDeFsOklqGcLhkR5sJV0kAOmgoFfG4Q72gGWMd4urFPFKIrCAJC8eLau/K/eQAAcSmS 6oXfMhrc5olw+9+HHUb5K2w/rnaARWeTFxrayIQEveEUS2DabrRADVxOqSyNIg7eM5Ic pwiUj3v9IX6l0E1uZRpCiXteqYpyHecVk4hm7LsyDu3Q4TJhlcroPTbwc1677itjAM+M 0T5ALxDxQI7gHkcyAnA/I02rW7hxNMkKH3FINIMp3XdYedIh/zquiuSySa4B00pJaJJl cNIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=q1EKn9j2FtU/5NboQOODHWM3vZN+UjF82zhvbN8nb9k=; b=PILGlj7McwAtHGNRyuYK7Qcoz0xhr7MNV9yrkihgBSssiB6mbqoL2AI9Ce8e2Iiazx OCuXYKYk3R+E1d4MMal3m0XEoWCv2T+QYfMdQ1XdlHbkWFkzKQ2rZixITON56vph3Xmu CuWOzLDzyRHF5pRqkPbLwUHF0AaR9apgFxwwMfpum7k0tKqZIZvqW9esdf/qZm38gE+o meHJ0Fz7Wjivh9YAQTt/DKLuwzO5wD2+FKVDuoi+/jrKbtyUUOtjV3SeHh64rjCQl+UV aiuqqDdOHH1YlKYfE0kDHBXWEM9w7aeY4N9rtxttuy6eP6kbcC/BpXTt8/266vUcGt1c YFEA== X-Gm-Message-State: AOAM531g8eYz87nx3MInColgkR47D1RluxQBSNSGCvBeVuH3On2uzWFB OuD8wl7YukdyljKzVLSrpADATDqLvs3SsQ== X-Google-Smtp-Source: ABdhPJwPUX9PvxFwTkKf4Gh25rl6Mr51/zal0qNIX0et9fv15KBh9Cdf3j3ybGhi4AATK6awdkZjYg== X-Received: by 2002:a05:6402:2813:b0:424:1882:d064 with SMTP id h19-20020a056402281300b004241882d064mr9783221ede.357.1650528329430; Thu, 21 Apr 2022 01:05:29 -0700 (PDT) Received: from [192.168.0.226] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i20-20020aa7c714000000b0041fbd14c34bsm11207571edq.4.2022.04.21.01.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 01:05:29 -0700 (PDT) Message-ID: <43cb61ac-461f-e6ff-b495-44f8befde79f@linaro.org> Date: Thu, 21 Apr 2022 10:05:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Content-Language: en-US To: Jacky Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ychuang570808@gmail.com Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, will@kernel.org, soc@kernel.org, cfli0@nuvoton.com References: <20220418082738.11301-1-ychuang3@nuvoton.com> <20220418082738.11301-6-ychuang3@nuvoton.com> <4e9eaede-2208-bd73-35ae-89e128562653@linaro.org> <80994f4b-136f-7669-4674-0c9826e88248@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <80994f4b-136f-7669-4674-0c9826e88248@nuvoton.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/04/2022 10:04, Jacky Huang wrote: > > > On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote: >> On 21/04/2022 08:39, Jacky Huang wrote: >>> >>> On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: >>>> On 18/04/2022 10:27, Jacky Huang wrote: >>>>> +properties: >>>>> + $nodename: >>>>> + const: '/' >>>>> + compatible: >>>>> + items: >>>>> + - enum: >>>>> + - nuvoton,ma35d1 >>>>> + - nuvoton,ma35d1-evb >>>>> + - nuvoton,ma35d1-iot >>>>> + - nuvoton,ma35d1-som512 >>>>> + - nuvoton,ma35d1-som1g >>>> This does not match your DTS and does not look reasonable (SoC >>>> compatible should not be part of this enum). Check some other board >>>> bindings for examples. >>>> >>>> >>>> Best regards, >>>> Krzysztof >>> I would like to modify it as follows: >>> >>> description: | >>>   Boards with an ARMv8 based Nuvoton SoC shall have the following >>>   properties. >>> >>> properties: >>>   $nodename: >>>     const: '/' >>>   compatible: >>>     oneOf: >>> >>>       - description: MA35D1 evaluation board >>>         items: >>>           - const: nuvoton,ma35d1-evb >>>           - const: nuvoton,ma35d1 >>> >>>       - description: MA35D1 IoT board >>>         items: >>>           - const: nuvoton,ma35d1-iot >> Instead just enum with all board compatibles. > > How about to modify it as the follows: > >   compatible: >     oneOf: > >       - description: MA35D1 evaluation board >         items: >           - enum: >               - nuvoton,ma35d1-evb >           - const: nuvoton,ma35d1 > >       - description: MA35D1 IoT board >         items: >           - enum: >               - nuvoton,ma35d1-iot >           - const: nuvoton,ma35d1 > >       - description: MA35D1 SOM board >         items: >           - enum: >               - nuvoton,ma35d1-som512 >               - nuvoton,ma35d1-som1g >           - const: nuvoton,ma35d1 > It's still almost the same. All boards together. You can add a comment next to the compatible if you want some user-friendly name. Best regards, Krzysztof