From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
Alexey Minnekhanov <alexeymin@postmarketos.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order
Date: Wed, 13 Sep 2023 09:19:15 +0200 [thread overview]
Message-ID: <43cd38f5-20ce-a97d-0906-55faf228b377@linaro.org> (raw)
In-Reply-To: <20230721-topic-rpm_clk_cleanup-v2-14-1e506593b1bd@linaro.org>
On 12/09/2023 15:31, Konrad Dybcio wrote:
> The last 2 clock-names entries for the USB2 controller were swapped,
> resulting in schema warnings:
>
> ['cfg_noc', 'core', 'mock_utmi', 'sleep'] is too short
> 'iface' was expected
> 'sleep' was expected
> 'mock_utmi' was expected
>
> Fix it and take the liberty to make the clock-names entries more
> readable.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index f11d2a07508c..316c8fd224e0 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1394,8 +1394,10 @@ usb2: usb@c2f8800 {
> <&gcc GCC_USB20_MASTER_CLK>,
> <&gcc GCC_USB20_MOCK_UTMI_CLK>,
> <&gcc GCC_USB20_SLEEP_CLK>;
> - clock-names = "cfg_noc", "core",
> - "mock_utmi", "sleep";
> + clock-names = "cfg_noc",
> + "core",
> + "sleep",
> + "mock_utmi";
Plus this is just incorrect... :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-13 7:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 01/14] arm64: dts: qcom: msm8916: Drop RPM bus clocks Konrad Dybcio
2023-09-13 7:07 ` Krzysztof Kozlowski
2023-09-13 8:47 ` Konrad Dybcio
2023-09-13 8:53 ` Krzysztof Kozlowski
2023-09-13 10:48 ` Konrad Dybcio
2023-09-13 11:14 ` Krzysztof Kozlowski
2023-09-13 11:14 ` Konrad Dybcio
2024-01-02 10:01 ` Aiqun Yu (Maria)
2023-09-12 13:31 ` [PATCH v2 02/14] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 03/14] arm64: dts: qcom: qcs404: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 04/14] dt-bindings: arm-smmu: Fix SDM630 clocks description Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 05/14] dt-bindings: usb: qcom,dwc3: Fix SDM660 clock description Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks Konrad Dybcio
2023-09-13 7:13 ` Krzysztof Kozlowski
2023-09-13 12:08 ` Konrad Dybcio
2023-09-14 6:26 ` Krzysztof Kozlowski
2023-09-14 7:41 ` Konrad Dybcio
2024-01-02 21:17 ` Marijn Suijten
2023-09-12 13:31 ` [PATCH v2 07/14] arm64: dts: qcom: msm8939: " Konrad Dybcio
2023-09-13 7:15 ` Krzysztof Kozlowski
2023-09-12 13:31 ` [PATCH v2 08/14] dt-bindings: remoteproc: qcom,adsp: Remove AGGRE2 clock Konrad Dybcio
2023-09-13 7:16 ` Krzysztof Kozlowski
2023-09-12 13:31 ` [PATCH v2 09/14] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Remove PNoC clock Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 10/14] remoteproc: qcom: q6v5-mss: Remove PNoC clock from 8996 MSS Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 11/14] arm64: dts: qcom: msm8998: Remove AGGRE2 clock from SLPI Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 12/14] arm64: dts: qcom: msm8996: " Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 14/14] arm64: dts: qcom: sdm630: Fix USB2 clock-names order Konrad Dybcio
2023-09-13 7:17 ` Krzysztof Kozlowski
2023-09-13 7:19 ` Krzysztof Kozlowski [this message]
2023-09-18 11:05 ` [PATCH v2 00/14] Clean up RPM bus clocks remnants Will Deacon
2023-09-20 18:30 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43cd38f5-20ce-a97d-0906-55faf228b377@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).