Re: [PATCH v7 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree

[Renjiang Han <quic_renjiang@quicinc.com>]

On 5/28/2025 7:04 PM, Dmitry Baryshkov wrote:
> On Wed, May 28, 2025 at 05:13:06PM +0800, Renjiang Han wrote:
>> On 5/27/2025 9:57 PM, Konrad Dybcio wrote:
>>> On 5/27/25 5:32 AM, Renjiang Han wrote:
>>>> Add the venus node to the devicetree for the qcs615 platform to enable
>>>> video functionality. The qcs615 platform currently lacks video
>>>> functionality due to the absence of the venus node. Fallback to sc7180 due
>>>> to the same video core.
>>>>
>>>> Signed-off-by: Renjiang Han <quic_renjiang@quicinc.com>
>>>> ---
>>> [...]
>>>
>>>> +			interconnect-names = "video-mem",
>>>> +					     "cpu-cfg";
>>>> +
>>>> +			iommus = <&apps_smmu 0xe40 0x20>;
>>> fwiw docs mention 0xe60 0x20 (which result in the exact same resulting sid)
>> OK. Will update it with next version.
> How would you update this?
Thanks for your comments. I'll update it like this.
iommus = <&apps_smmu 0xe60 0x20>;

This 0xe40 SID was based on a previous project. However, after rechecking
the documentation yesterday and confirming with colleagues, the correct
SID value should be 0xe60. I’ve also validated it on local device, it
works as expected. The reason 0xe40 seemed to work earlier is due to the
mask value being 0x20, which causes the effective SID derived from 0xe40
to be the same as 0xe60.
>
-- 
Best Regards,
Renjiang