Re: [PATCH v3 1/1] USB: core: let USB device know device node

Peter Chen
2016-01-21T09:48:32Z

On Thu, Jan 21, 2016 at 09:41:20AM +0100, Arnd Bergmann wrote:
> On Thursday 21 January 2016 11:15:24 Peter Chen wrote:
> >
> > Just adding from device driver view and change the name from "roohub" to
> > "port".
> >
> > It is the port number (1-9), but not the root hub number.
> >
> > At the most of embedded platforms, we have only one port per controller.
> > For example, at the non-hub boards, if there are two Standard-A ports,
> > there are from two different USB controllers.
> > But for Alan's case, it has six ports, and all from the one USB controller,
> > port 1 to port 6 are from the HS root hub, port 7 to port 9 are from the SS
> > root hub.
> >
> > For the single port controller platform, the dts will be like below, port_1 is
> > under the HS root hub, port_2 is under the SS root hub.
> >
> > &usb1 {
> > port_1: nxp@1 {
> > compatible = "usb15a2,007d";
> > reg = <0x01>;
> >
> > hub: genesys@1 {
> > compatible = "usb05e3,0608";
> > reg = <0x01>;
> > };
> > };
> >
> > port_2: nxp@2 {
> > compatible = "usb15a2,007d";
> > reg = <0x02>;
> >
> > hub: genesys@1 {
> > compatible = "usb05e3,0608";
> > reg = <0x01>;
> > };
> > };
> > };
>
> But why are you modeling ports of the root hub as hubs themselves?
>
> I would expect the example above to look like
>
> &usb1 {
> hub@1 {
> compatible = "usb05e3,0608";
> reg = <0x01>;
> };
>
> hub@2 {
> compatible = "usb05e3,0608";
> reg = <0x01>;
> };
> };

You are right, I should not add root hub or port description in
device tree, only the description for the device on that port is enough.

>
> So two hubs at ports 1 and 2 of the USB controller that integrates
> the root hub and shares a device node with it.
>

Ok, so the "reg" is the address for certain root hub (HS or SS), not
the unity address for the whole controller, if it is, do we really
need to add two nodes for one physical port, HS and SS will not be used
at the same time. And if the reg is the same, how can we know
which node is from current recognized device.

--

Best Regards,
Peter Chen