From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E913E3156; Fri, 26 Jun 2026 07:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459650; cv=none; b=SdftYWx+d53Ko3W/2mjXwy4HAMpar4m4RS6Fzk5dScjU1QdZdakS5SbB0izdXOmuIO/NoUDbU90v9/fR5+wXI5bLyffGIv18XOwW8ce7CUSiU1sHTIW+VY1xRQ7VUQuULIFhYKQ8t6iUHHy01A5SRuffhx9EnAsZX24Bm2GUJTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782459650; c=relaxed/simple; bh=GZqXT9Ip/JO+OGFUfsAmg+5Z5295gCYwwiBd6y9iYj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XhRE8jdEb3n40ZzpNmREH23jPbdc026JpJr+fg6n/4pTFhaGvwj3uYx6Zcqpu1pksMTsv8nBLWioetdP6+2PDKZiuBXHHW8NdpgxByooLjbOQi+0h8587RkAeBvJt/j3mO0NXmZeVNYyVkxIiJbFUoL5OLPFI+OGk3lLyZOI75M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l8DprBuf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l8DprBuf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D7941F000E9; Fri, 26 Jun 2026 07:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782459649; bh=N8XrY+wXxLK2NxQ4BW48R9sEgb+goFZ/Ui0Zz6LHgw0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=l8DprBuf6Iya+bmN6b3AdCa8GMgRBC09SjyD/wZcdFS3TzPLlTlsrIseVwqO2Qw1M U++7kuXoVfJCjDF5CnHLBj9ypbGqqOevTtZBwQs1q/ybBGg1QmhgP9AeBsv//Cd8Mj ZDiBrIJb9d86SMlKQAnTdPlTHjZYv/eZHkwH7BWnqUQeUrY9UwDlwq1Izw1WrjWXPI OQpfRiRS5oNwNuY6y/OSasdaMbBNW64cvtwZHteqH8ileT1TUaMCaC42WxY3eFizwZ 3GjUKcqfkiIp6QghQ1vZg0R/QDymYEAVCWnzNI0YeSdqiQ2CrkycbjsP7F8xWKzkXL g1X1fA+nTQkiw== Message-ID: <440a78ed-2ac9-4926-affd-8697348eb83d@kernel.org> Date: Fri, 26 Jun 2026 09:40:40 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver To: Sunyun Yang , Dmitry Baryshkov Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com, rfoss@kernel.org, mripard@kernel.org, Laurent.pinchart@ideasonboard.com, tzimmermann@suse.de, jonas@kwiboo.se, jernej.skrabec@gmail.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xmzhu@lontium.corp-partner.google.com, xmzhu@lontium.com, rlyu@lontium.com, xbpeng@lontium.com References: <20260508134009.4582-1-syyang@lontium.com> <20260508134009.4582-3-syyang@lontium.com> <3188f63f-5358-48d7-b934-af20a8f95c6f@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26/06/2026 03:55, Sunyun Yang wrote: > Dmitry Baryshkov 于2026年6月25日周四 22:57写道： >> >> On Thu, Jun 25, 2026 at 09:26:47PM +0800, Sunyun Yang wrote: >>> Krzysztof Kozlowski 于2026年6月25日周四 21:17写道： >>>> >>>> On 25/06/2026 15:14, Sunyun Yang wrote: >>>>> Krzysztof Kozlowski 于2026年6月25日周四 20:54写道： >>>>>> >>>>>> On 08/05/2026 15:40, syyang@lontium.com wrote: >>>>>>> + >>>>>>> +static void lt9611c_reset(struct lt9611c *lt9611c) >>>>>>> +{ >>>>>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 1); >>>>>>> + msleep(20); >>>>>>> + >>>>>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 0); >>>>>>> + msleep(20); >>>>>>> + >>>>>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 1); >>>>>> >>>>>> This is just plain wrong. Why do you assert, then de-assert and then >>>>>> finally assert AGAIN the reset leaving the device in powerdown stage? >>>>>> >>>>> I am using software to emulate the hardware RESET button on our EVB. >>>>> When the hardware RESET button is pressed while our chip is running, >>>>> the signal level changes from HIGH to LOW and then back to HIGH. >>>>> >>>>> Of course, we can also use the following: >>>>> static void lt9611c_reset(struct lt9611c *lt9611c) >>>>> { >>>>> gpiod_set_value_cansleep(lt9611c->reset_gpio, 0); >>>>> msleep(50); >>>>> gpiod_set_value_cansleep(lt9611c->reset_gpio, 1); >>>>> msleep(20); >>>>> } >>>> >>>> Makes no sense either and you just did not get the point and did not >>>> answer my question. I asked WHY you leave asserted. Answer "we emulate" >>>> is just plain wrong. >>>> >>>> So again please answer: >>>> >>>> Why do you leave device with reset asserted? >>>> >>> >>> devicetree: reset-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH>; >> >> It should be GPIO_ACTIVE_LOW, if the pin as active-low. >> > > Yes, I understand that. > > I used GPIO_ACTIVE_HIGH intentionally, because I did not want to > modify the existing reset-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH> > property in the lontium-lt9611.yaml device tree file that was The example there does not matter. You must write correct driver. That is it. If you cannot bring the arguments why reset must be asserted for the normal operation of the device, then this is the end of discussion. Best regards, Krzysztof