From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 266A3D5; Sun, 3 Dec 2023 11:48:55 -0800 (PST) Received: from i53875b61.versanet.de ([83.135.91.97] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r9sSK-00062s-Af; Sun, 03 Dec 2023 20:48:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Tim Lunn , Andi Shyti Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Jagan Teki , Conor Dooley , linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org Subject: Re: [PATCH v3 3/8] i2c: rk3x: Adjust mask/value offset for i2c2 on rv1126 Date: Sun, 03 Dec 2023 20:48:43 +0100 Message-ID: <4413905.22IY78Rhhi@diego> In-Reply-To: <20231203190620.26of3xrcoosnpicb@zenone.zhora.eu> References: <20231203124004.2676174-1-tim@feathertop.org> <20231203124004.2676174-4-tim@feathertop.org> <20231203190620.26of3xrcoosnpicb@zenone.zhora.eu> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Andi, Am Sonntag, 3. Dezember 2023, 20:06:20 CET schrieb Andi Shyti: > Hi Tim, > > On Sun, Dec 03, 2023 at 11:39:59PM +1100, Tim Lunn wrote: > > Rockchip RV1126 is using old style i2c controller, the i2c2 > > bus uses a non-sequential offset in the grf register for the > > mask/value bits for this bus. > > > > This patch fixes i2c2 bus on rv1126 SoCs. > > > > Signed-off-by: Tim Lunn > > Acked-by: Heiko Stuebner > > Reviewed-by: Andi Shyti you're listed as the maintainer for the i2c busses, are you going to pick this one patch yourself? Or do you expect a different handling? I.e. it doesn't really tie into the dts patches and everything will come together nicely in linux-next and during the next merge-window. Thanks Heiko