From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] Revert "[media] tvp5150: document input connectors DT bindings" Date: Tue, 23 Feb 2016 21:11:33 +0200 Message-ID: <4415195.KUYSOd2PzY@avalon> References: <1456253288-397-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1456253288-397-1-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , devicetree@vger.kernel.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Javier, Thank you for the patch. On Tuesday 23 February 2016 15:48:08 Javier Martinez Canillas wrote: > This reverts commit 82c2ffeb217a ("[media] tvp5150: document input > connectors DT bindings") since the DT binding is too device driver > specific and should instead be more generic and use the bindings > in Documentation/devicetree/bindings/display/connector/ and linked > to the tvp5150 using the OF graph port and endpoints. > > There are still ongoing discussions about how the input connectors > will be supported by the Media Controller framework so until that > is settled, it is better to revert the connectors portion of the > bindings to avoid known to be broken bindings docs to hit mainline. > > Suggested-by: Laurent Pinchart > Signed-off-by: Javier Martinez Canillas Acked-by: Laurent Pinchart > > --- > > .../devicetree/bindings/media/i2c/tvp5150.txt | 43 ------------------ > 1 file changed, 43 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt > b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt index > daa20e43a8e3..8c0fc1a26bf0 100644 > --- a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt > +++ b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt > @@ -12,32 +12,6 @@ Optional Properties: > - pdn-gpios: phandle for the GPIO connected to the PDN pin, if any. > - reset-gpios: phandle for the GPIO connected to the RESETB pin, if any. > > -Optional nodes: > -- connectors: The input connectors of tvp5150 have to be defined under > - a subnode name "connectors" using the following format: > - > - input-connector-name { > - input connector properties > - }; > - > -Each input connector must contain the following properties: > - > - - label: a name for the connector. > - - input: the input connector. > - > -The possible values for the "input" property are: > - 0: Composite0 > - 1: Composite1 > - 2: S-Video > - > -and on a tvp5150am1 and tvp5151 there is another: > - 4: Signal generator > - > -The list of valid input connectors are defined in > dt-bindings/media/tvp5150.h -header file and can be included by device tree > source files. > - > -Each input connector can be defined only once. > - > The device node must contain one 'port' child node for its digital output > video port, in accordance with the video interface bindings defined in > Documentation/devicetree/bindings/media/video-interfaces.txt. > @@ -62,23 +36,6 @@ Example: > pdn-gpios = <&gpio4 30 GPIO_ACTIVE_LOW>; > reset-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>; > > - connectors { > - composite0 { > - label = "Composite0"; > - input = ; > - }; > - > - composite1 { > - label = "Composite1"; > - input = ; > - }; > - > - s-video { > - label = "S-Video"; > - input = ; > - }; > - }; > - > port { > tvp5150_1: endpoint { > remote-endpoint = <&ccdc_ep>; -- Regards, Laurent Pinchart