From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lorenzo Pieralisi" Subject: RE: [RFC PATCH 13/14] ARM: vexpress: Definition of vexpress dts specification Date: Fri, 20 Aug 2010 18:51:08 +0100 Message-ID: <44188.7445319027$1282326700@news.gmane.org> References: <1282158000-23081-1-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-2-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-3-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-4-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-5-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-6-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-7-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-8-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-9-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-10-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-11-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-12-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-13-git-send-email-lorenzo.pieralisi@arm.com> <1282158000-23081-14-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-gb List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: 'Grant Likely' Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org, Catalin Marinas , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Philippe Robin , jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org [mailto:glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org] On Behalf Of Gra= nt > Likely > Sent: 18 August 2010 22:55 > To: Lorenzo Pieralisi > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Philippe Robin; nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org; > linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org; Catalin Marinas; jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org > Subject: Re: [RFC PATCH 13/14] ARM: vexpress: Definition of vexpress dts > specification > = > On Wed, Aug 18, 2010 at 12:59 PM, Lorenzo Pieralisi > wrote: > > The device tree methodology requires a dts file to be defined per > > platform in order to describe the platform address space and topology, > > in short the device tree in source format. > > > > This patch adds the dts file for the Versatile Express board. > > Some device names are still temporary and non-compliant waiting for the > > definition of proper clock bindings. > > > > Signed-off-by: Lorenzo Pieralisi > > --- > > =A0arch/arm/boot/dts/vexpress.dts | =A0199 > ++++++++++++++++++++++++++++++++++++++++ > > =A01 files changed, 199 insertions(+), 0 deletions(-) > > =A0create mode 100644 arch/arm/boot/dts/vexpress.dts > > > > diff --git a/arch/arm/boot/dts/vexpress.dts > b/arch/arm/boot/dts/vexpress.dts > > new file mode 100644 > > index 0000000..cc58603 > > --- /dev/null > > +++ b/arch/arm/boot/dts/vexpress.dts > > @@ -0,0 +1,199 @@ > > +/dts-v1/; > > + > > +/ { > > + =A0 =A0 =A0 model =3D "versatile-express"; > > + =A0 =A0 =A0 compatible =3D "arm,versatile-express"; > > + =A0 =A0 =A0 #address-cells =3D <1>; > > + =A0 =A0 =A0 #size-cells =3D <1>; > > + =A0 =A0 =A0 #interrupt-cells =3D <1>; > = > #interrupt-cells does not belong in the root node. You can remove this. > = > > + =A0 =A0 =A0 interrupt-parent =3D <&intc>; > > + > > + =A0 =A0 =A0 memory { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 name =3D "memory"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "memory"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x60000000 0x20000000>; > > + =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 chosen { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 bootargs =3D "rdinit=3D/bin/ash console= =3DttyAMA0 vga=3D0x311 > mem=3D512M debug earlyprintk"; > > + =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 soc { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "soc"; > = > Remove device_type property. It only has meaning when real > OpenFirmware is present on the board. OK. > = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "simple-bus"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ranges =3D <0x00000000 0x00000000 0xFFFFF= FFF>; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 gic-cpu { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #interrupt-cells =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupt-controller; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x1e000100 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,gic-c= pu-interrupt-controller"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "gic"; > = > Ditto on device_type > OK. = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 intc: gic-dist { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #interrupt-cells =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupt-controller; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x1e001000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,gic-d= ist-interrupt-controller"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "gic"; > = > Ditto > = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq-start =3D <29>; > = > This ends up encoding Linux-kernel implementation details into the > device tree. Ideally the Linux irq numbers are to be dynamically > assigned by the kernel for each interrupt controller, but I haven't > ported the support code for that yet. Shouldn't be too hard to do > though. > = Ok, let's keep in sync on this, see below. > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 smsc@4e000000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "smc,smsc-= 911"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg =3D <0x4e000000 0x= 1000>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <47>; > = > I suspect this interrupts property is wrong. An interrupts specifier > is specific to the interrupt controller node; so this should always > specify the interrupt input on a specific controller (either gic-cpu > or gic-dist in this system). It looks like '47' is the global irq > number. Am I correct? > Strictly related to the previous point. When you say input Grant you mean input HW pin or interrupt HW ID ? I think you mean the irq ID specific to a given interrupt controller, = because that is what SW sees and controls. 47 is the eth interrupt ID on the gic-dist, that in this particular case becomes the global IRQ number as well if I am not mistaken. = (it is retrieved through the platform device resource). I think it is correct as it is, but I will countercheck. > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 flags =3D <2>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq-polarity =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq-type =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phy-interface =3D <0>; > = > As mentioned in my comments on the smsc911x driver changes, there > already is a binding for the phy which should be used, and the irq > flags should be specified as a second cell in the 'interrupts' > property. This also means that the interrupt controller nodes should > probably use #interrupt-cells =3D <2>; > = Ok, I will patch the dts accordingly. > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 flash@40000000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,arm-f= lash"; > = > Use "cfi-flash" which the physmap_of.c driver will bind against. > = Ok, I will follow Catalin's reply up. > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x40000000 0x400= 0000 > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00x44000000= 0x4000000>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 isp@4f000000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "nxp,usb-i= sp1761"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x4f000000 0x200= 00>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <48>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 port1_otg; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ddc@10016000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,versa= tile-i2c"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10016000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 pmu@0 { > = > If there is no 'reg' property, then there should not be a @0 component > to the node name. > Ok. = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,arm-p= mu"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <92 93 94 = 95>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 timer@10011000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,arm-s= p804"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10011000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <34>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 timer@10012000 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,arm-s= p804"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10012000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 amba { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <1>; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 uart@0 { > = > uart@10009000 > = > The @ portion of the node name consists of the first > #address-cells values of the reg property separated by commas. If > #address-cells =3D <1>, then it is just a single number like in this > case. > Yes Grant, consider it done, I left them like that because the clock = look-up uses the name (before merging your changes) and I avoided recoding the clock LUT before posting the patchset. = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10009000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00141011>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <37>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 uart@1 { > = > ditto (and so on down the file) > = > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x1000a000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00141011>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <38>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 kbd@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10006000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041050>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <44>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 aaci@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10004000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041041>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <43>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ps2@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10007000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041050>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <45>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 rtc@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10017000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041031>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <36>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 wdt@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,amba-= device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x1000f000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041085>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <32>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 clcd@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,clcd-= pl11x","arm,amba-device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10020000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arm,amba-deviceid =3D <0x= 00041111>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <76>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 mmci@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,mmc-p= l18x","arm,amba-device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x10005000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <41 42>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 dmc@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,dmc",= "arm,amba-device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x100e0000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 smc@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,smc",= "arm,amba-device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x100e1000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <77 78>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 gpio@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "arm,gpio"= ,"arm,amba-device"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x100e8000 0x100= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <82>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-map =3D <&ref24_clk= 0>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }; > > + =A0 =A0 =A0 }; > > + > > + =A0 =A0 =A0 clocks { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ref24_clk: clock@0 { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "clock"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fixed-clo= ck"; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-frequency =3D <2400= 0000>; > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-output-names =3D "r= ef"; > = > This will of course need to be updated to the clock binding that > Jeremy and I have settled on, but you already knew that. :-) > = Yes, again, you are right I knew that but I wanted to post a version = I completely tested before applying the new clock bindings when rebasing. I will update the code for the next respin. > Cheers, > g. Thanks a lot, Lorenzo