From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI
Date: Wed, 13 Jul 2016 10:32:30 +0200 [thread overview]
Message-ID: <4424049.9GWmiGNCEh@wuerfel> (raw)
In-Reply-To: <1468398000.319627182-MSam/alRxCtsdVUOrk1QfQ@public.gmane.org>
On Wednesday, July 13, 2016 11:20:00 AM CEST Alexander Shiyan wrote:
> >Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>:
> >
> >On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote:
> >> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
> >> > +
> >> > +An additional register is present in the system controller,
> >> > +which is assumed to be in the same device tree, with and marked
> >> > +as compatible with "cirrus,ep7209-syscon3".
> >> > +
> >> > +Example:
> >> > +
> >> > +spi@80000500 {
> >> > + #address-cells = <1>;
> >> > + #size-cells = <0>;
> >> > + compatible = "cirrus,ep7209-spi";
> >> > + reg = <0x80000500 0x4>;
> >> > + interrupts = <15>;
> >> > + clocks = <&clks CLPS711X_CLK_SPI>;
> >> > + status = "disabled";
> >> > +};
> >> > +
> >> > +syscon3: syscon@80002200 {
> >>
> >> This looks like it shouldn't be here.
> >
> >The label, or the entire node?
>
> I think that the whole syscon3 node is redundant.
The node is needed here because it is required for the device to
work: the binding doesn't contain a label for the syscon reference
but as I documented above, any driver will have to look up the
syscon by compatible string.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-07-13 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 9:49 [PATCH v2 1/2] spi: clps711x: Driver refactor Arnd Bergmann
[not found] ` <20160707094952.4111577-1-arnd-r2nGTMty4D4@public.gmane.org>
2016-07-07 9:49 ` [PATCH v2 2/2] spi: add DT binding for clps711x SPI Arnd Bergmann
2016-07-12 20:49 ` Rob Herring
2016-07-13 8:13 ` Arnd Bergmann
2016-07-13 8:20 ` Alexander Shiyan
[not found] ` <1468398000.319627182-MSam/alRxCtsdVUOrk1QfQ@public.gmane.org>
2016-07-13 8:32 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4424049.9GWmiGNCEh@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=shc_work-JGs/UdohzUI@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).