From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 Date: Wed, 10 Dec 2014 15:41:15 +0100 Message-ID: <4428865.bnDr16Yqvr@wuerfel> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <2545975.QDuBFbG7BN@wuerfel> <1418222233.21309.17.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1418222233.21309.17.camel@mtksdaap41> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yingjoe Chen Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eddie Huang , Matthias Brugger , Rob Herring , Jason Cooper , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Pawel Moll , Ian Campbell , Catalin Marinas , Mark Brown , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robert Richter , Sascha Hauer , Kumar Gala , Olof Johansson , Thomas Gleixner , yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 10 December 2014 22:37:13 Yingjoe Chen wrote: > OK, I'll change to something like this in next version: I've just taken another look at the driver and have a different suggestion: > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt > @@ -17,12 +17,17 @@ Required properties: > use the same interrupt-cells format as GIC. > - reg: Physical base address of the intpol registers and length of memory > mapped region. > > +Optional properties: > +- mediatek,intpol-number: The number of interrupts supported by intpol, > + default 224 if omitted. > + > Example: > sysirq: interrupt-controller@10200100 { > compatible = "mediatek,mt6589-sysirq", "mediatek,mt6577-sysirq"; > interrupt-controller; > #interrupt-cells = >; > interrupt-parent = <&gic>; > reg = <0 0x10200100 0 0x1c>; > + mediatek,intpol-number = <224>; > }; The number of interrupt pins directly corresponds to the size of the reg property in bits, so I think you can just use that and don't even need another property. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html