From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
quic_wcheng@quicinc.com, quic_kriskura@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb
Date: Wed, 17 Jul 2024 11:55:44 +0200 [thread overview]
Message-ID: <442956f4-ca5b-4ff8-bc02-bcad4dce50e9@linaro.org> (raw)
In-Reply-To: <20240717094848.3536239-2-quic_varada@quicinc.com>
On 17.07.2024 11:48 AM, Varadarajan Narayanan wrote:
> Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH
> instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not
> supported for SPIs and results in probe failure with -EINVAL.
>
> Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332")
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index f58fd70be826..56304f996dbf 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -322,8 +322,8 @@ usb: usb@8af8800 {
> reg = <0x08af8800 0x400>;
>
> interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>,
> - <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>;
> + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Probably worth asking, is there a MPM/PDC on this platform?
Konrad
next prev parent reply other threads:[~2024-07-17 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 9:48 [PATCH v2 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info Varadarajan Narayanan
2024-07-17 9:48 ` [PATCH v2 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb Varadarajan Narayanan
2024-07-17 9:55 ` Konrad Dybcio [this message]
2024-07-17 15:15 ` Dmitry Baryshkov
2024-07-18 6:23 ` [PATCH v2 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info Krzysztof Kozlowski
2024-07-23 10:05 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442956f4-ca5b-4ff8-bc02-bcad4dce50e9@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).