devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Herve Codina <herve.codina@bootlin.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support
Date: Sat, 14 May 2022 12:35:51 +0300	[thread overview]
Message-ID: <4436479e-c0ef-4962-7ad3-2b8b80e1643a@gmail.com> (raw)
In-Reply-To: <20220513105850.310375-4-herve.codina@bootlin.com>

Hello!

On 5/13/22 1:58 PM, Herve Codina wrote:

> Add UDPHS (the USB High Speed Device Port controller) support.
> The UDPHS IP present in the lan966x SOC is the same as the one
> present in the SAMA5D3 SOC
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
>  arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 7d2869648050..4c09f3166d27 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -211,6 +211,17 @@ can0: can@e081c000 {
>  			status = "disabled";
>  		};
>  
> +		udc: udphs@e0808000 {

   Shouldn't it be:

		udphs: udc@e0808000 {

(as the node names should be generic)?

[...]

MBR, Sergey

  parent reply	other threads:[~2022-05-14  9:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 10:58 [PATCH 0/3] Microchip LAN966x USB device support Herve Codina
2022-05-13 10:58 ` [PATCH 1/3] clk: lan966x: Fix the lan966x clock gate register address Herve Codina
2022-05-13 10:58 ` [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Herve Codina
2022-05-13 12:57   ` Krzysztof Kozlowski
2022-05-20 11:34     ` Herve Codina
2022-05-20 11:40       ` Krzysztof Kozlowski
2022-05-20 12:21         ` Herve Codina
2022-05-20 12:50           ` Krzysztof Kozlowski
2022-05-20 13:02             ` Herve Codina
2022-05-20 13:38               ` Krzysztof Kozlowski
2022-05-20 13:52                 ` Alexandre Belloni
2022-05-20 14:05                   ` Krzysztof Kozlowski
2022-05-20 14:12                   ` Herve Codina
2022-05-13 10:58 ` [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support Herve Codina
2022-05-13 12:54   ` Krzysztof Kozlowski
2022-05-20 12:37     ` Herve Codina
2022-05-20 12:48       ` Krzysztof Kozlowski
2022-05-14  9:35   ` Sergei Shtylyov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-20 15:23 [PATCH 0/3] Microchip LAN966x USB device support Herve Codina
2022-05-20 15:23 ` [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support Herve Codina
2022-05-23  8:10   ` Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4436479e-c0ef-4962-7ad3-2b8b80e1643a@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herve.codina@bootlin.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).