devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Fabio Berton <fabio.berton@ossystems.com.br>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 07/13] ARM: dts: rv1108: Fix the timer mask
Date: Mon, 26 Nov 2018 06:26:36 +0100	[thread overview]
Message-ID: <4443441.F7S2jYBxxL@phil> (raw)
In-Reply-To: <20181125211907.9895-7-otavio@ossystems.com.br>

Am Sonntag, 25. November 2018, 22:19:01 CET schrieb Otavio Salvador:
> As done in the Rockchip vendor tree and also on other
> "arm,armv7-timer" instances, the correct GIC_CPU_MASK_SIMPLE mask
> is 4 instead of 1.

Nope. That value represents the number of cores in the system.
As the rv1108 only has one core, that should likely stay as it is.

Also, it seems I only got patches 6-13 what happened to 1-5?

Heiko

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> ---
> 
>  arch/arm/boot/dts/rv1108.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index c7a26f82655b..7b331766120d 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -71,8 +71,8 @@
>  
>  	timer {
>  		compatible = "arm,armv7-timer";
> -		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>,
> -			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>;
> +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>,
> +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
>  		clock-frequency = <24000000>;
>  	};
>  
> 

  reply	other threads:[~2018-11-26  5:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181125211907.9895-1-otavio@ossystems.com.br>
2018-11-25 21:19 ` [PATCH 06/13] ARM: dts: rv1108: Add GMAC support Otavio Salvador
2018-11-26  9:14   ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 07/13] ARM: dts: rv1108: Fix the timer mask Otavio Salvador
2018-11-26  5:26   ` Heiko Stuebner [this message]
2018-11-26 13:45     ` Otavio Salvador
2018-11-25 21:19 ` [PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number Otavio Salvador
2018-11-26  5:58   ` Heiko Stuebner
2018-11-26 13:36     ` Otavio Salvador
2018-11-26 13:46       ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 09/13] ARM: dts: rv1108: Assign the proper GPIO clocks Otavio Salvador
2018-11-25 21:19 ` [PATCH 10/13] ARM: dts: rv1108: Add UART DMA support Otavio Salvador
2018-11-25 21:19 ` [PATCH 11/13] ARM: dts: rv1108: Add internal timer support Otavio Salvador
2018-11-26  8:57   ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 12/13] ARM: dts: rv1108: Pass the 'arm,cpu-registers-not-fw-configured' property Otavio Salvador
2018-11-26  9:29   ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 13/13] ARM: dts: rv1108: Pass the 'clock-latency' property Otavio Salvador
2018-11-26  9:25   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4443441.F7S2jYBxxL@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.berton@ossystems.com.br \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=otavio@ossystems.com.br \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).