From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nick Hainke <vincent@systemli.org>, linux-mediatek@lists.infradead.org
Cc: INAGAKI Hiroshi <musashino.open@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Ryder Lee <ryder.lee@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: mt7622: fix BPI-R64 WPS button
Date: Thu, 7 Jul 2022 16:45:26 +0200 [thread overview]
Message-ID: <4447e5dc-8c79-7260-2d65-d86b5416d9a2@gmail.com> (raw)
In-Reply-To: <20220630111746.4098-1-vincent@systemli.org>
On 30/06/2022 13:16, Nick Hainke wrote:
> The bananapi R64 (BPI-R64) experiences wrong WPS button signals.
> In OpenWrt pushing the WPS button while powering on the device will set
> it to recovery mode. Currently, this also happens without any user
> interaction. In particular, the wrong signals appear while booting the
> device or restarting it, e.g. after doing a system upgrade. If the
> device is in recovery mode the user needs to manually power cycle or
> restart it.
>
> The official BPI-R64 sources set the WPS button to GPIO_ACTIVE_LOW in
> the device tree. This setting seems to suppress the unwanted WPS button
> press signals. So this commit changes the button from GPIO_ACTIVE_HIGH to
> GPIO_ACTIVE_LOW.
>
> The official BPI-R64 sources can be found on
> https://github.com/BPI-SINOVOIP/BPI-R64-openwrt
>
> Fixes: 0b6286dd96c0 ("arm64: dts: mt7622: add bananapi BPI-R64 board")
>
> Suggested-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> Signed-off-by: Nick Hainke <vincent@systemli.org>
Applied, thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index 2b9bf8dd14ec..7538918c7a82 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -49,7 +49,7 @@ factory {
> wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> - gpios = <&pio 102 GPIO_ACTIVE_HIGH>;
> + gpios = <&pio 102 GPIO_ACTIVE_LOW>;
> };
> };
>
prev parent reply other threads:[~2022-07-07 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:16 [PATCH] arm64: dts: mt7622: fix BPI-R64 WPS button Nick Hainke
2022-07-07 14:45 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4447e5dc-8c79-7260-2d65-d86b5416d9a2@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=musashino.open@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).