Re: [PATCH 5/5] ARM: dts: qcom: msm8974-oneplus-bacon: Add notification LED

Pavel Machek
2023-02-11T16:22:43Z

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hi!

> > Unfortunately the driver currently supports neither multicolor API nor
> > using the properties function & color, so we use label instead.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > .../arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 28 ++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > index ffb486ceb6a6..a672c45d7070 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> > @@ -114,6 +114,34 @@ led@0 {
> > default-brightness = <80>;
> > };
> > };
> > +
> > + led-controller@68 {
> > + compatible = "si-en,sn3193";
> > + reg = <0x68>;
> > +
> > + shutdown-gpios = <&tlmm 45 GPIO_ACTIVE_HIGH>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + led@1 {
> > + reg = <1>;
> > + label = "red:status";
>
> These should be colors and functions.

Yep. Plus this is one LED, not three, so it should use the multicolor
class.

And then we should have an entry in
Documentation/leds/well-known-leds.txt so that we have same ABI on all
the phones.

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]