devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Icenowy Zheng <uwu@icenowy.me>,
	Hal Feng <hal.feng@starfivetech.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] dt-bindings: riscv: Add StarFive JH7110S SoC and VisionFive 2 Lite board
Date: Sun, 24 Aug 2025 12:48:21 -0700	[thread overview]
Message-ID: <44585871-aabe-4d6d-b4c9-17d9acaa8063@freeshell.de> (raw)
In-Reply-To: <3c2b62e219e50555319da369cafa9a8f79eb71e8.camel@icenowy.me>

On 8/24/25 10:14, Icenowy Zheng wrote:
> 在 2025-08-21星期四的 18:09 +0800,Hal Feng写道:
>> Add device tree bindings for the StarFive JH7110S SoC
>> and the VisionFive 2 Lite board equipped with it.
>>
>> JH7110S SoC is an industrial SoC which can run at -40~85 degrees
>> centigrade
>> and up to 1.25GHz. Its CPU cores and peripherals are mostly similar
>> to
>> those of the JH7110 SoC.
>>
>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>>  Documentation/devicetree/bindings/riscv/starfive.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml
>> b/Documentation/devicetree/bindings/riscv/starfive.yaml
>> index 7ef85174353d..a2952490709f 100644
>> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
>> @@ -33,6 +33,11 @@ properties:
>>                - starfive,visionfive-2-v1.3b
>>            - const: starfive,jh7110
>>  
>> +      - items:
>> +          - enum:
>> +              - starfive,visionfive-2-lite
>> +          - const: starfive,jh7110s
> 
> I suggest adding starfive,jh7110 as a fallback here, as it's the SoC
> best known to most softwares, and JH7110S shouldn't have any difference
> to JH7110 other than binning.
> 
>> +
>>  additionalProperties: true
>>  
>>  ...
> 

NAK, it is said the operating parameters of jh7110s are distinct from
jh7110. You would have to show that it is safe to operate the jh7110s
with the operating parameters of the jh7110. If anything this would be
the inverse, some jh711x (or even j71xx to include jh7100) common
description with fallback operating parameters? And to add this common
fallback with jh7100 (?), jh7110, jh7110s  -E

  reply	other threads:[~2025-08-24 19:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 10:09 [RFC 0/3] Add support for StarFive VisionFive 2 Lite board Hal Feng
2025-08-21 10:09 ` [RFC 1/3] dt-bindings: riscv: Add StarFive JH7110S SoC and " Hal Feng
2025-08-21 18:17   ` Conor Dooley
2025-08-22  7:37     ` Hal Feng
2025-08-22 16:37       ` Conor Dooley
2025-08-24 17:14   ` Icenowy Zheng
2025-08-24 19:48     ` E Shattow [this message]
2025-08-21 10:09 ` [RFC 2/3] riscv: dts: starfive: jh7110-common: Move out some nodes to the board dts Hal Feng
2025-08-21 15:07   ` E Shattow
2025-08-22  6:11     ` Hal Feng
2025-08-21 10:09 ` [RFC 3/3] riscv: dts: starfive: Add VisionFive 2 Lite board device tree Hal Feng
2025-08-21 14:08   ` Vivian Wang
2025-08-22  2:13     ` Hal Feng
2025-08-23 19:32   ` E Shattow
2025-08-25  3:20     ` Hal Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44585871-aabe-4d6d-b4c9-17d9acaa8063@freeshell.de \
    --to=e@freeshell.de \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).