From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Alexander Stein <alexander.stein@mailbox.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format
Date: Wed, 9 Aug 2023 16:23:35 +0200 [thread overview]
Message-ID: <4462f00f-f590-df44-97d0-a657b3da2559@linaro.org> (raw)
In-Reply-To: <1j1qgcba54.fsf@starbuckisacylon.baylibre.com>
On 09/08/2023 15:46, Jerome Brunet wrote:
>
> On Wed 09 Aug 2023 at 15:02, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 09/08/2023 08:58, Jerome Brunet wrote:
>>>>> + required:
>>>>> + - '#reset-cells'
>>>>
>>>> else:
>>>> properties:
>>>> '#reset-cells': false
>>>> ???
>>>>
>>>>
>>>> You need to constrain the clocks per variant. Probably names are also
>>>> specific to each one, so the list of names can be moved here and you
>>>> keep just min/maxItems in the top level property.
>>>>
>>>
>>> input clock names and constraints are the same for all 3 variants.
>>
>> Then why do you have this huge, apparently unnecessary, oneOf? If it's
>> the same, then drop the oneOf and make number of clocks fixed.
>>
>
> As I pointed out, this section is wrong.
Ah, I misunderstood. Looks good, thanks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-09 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 19:48 [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format Alexander Stein
2023-08-09 6:15 ` Jerome Brunet
2023-08-09 18:37 ` Alexander Stein
2023-08-09 6:38 ` Krzysztof Kozlowski
2023-08-09 6:58 ` Jerome Brunet
2023-08-09 13:02 ` Krzysztof Kozlowski
2023-08-09 13:46 ` Jerome Brunet
2023-08-09 14:23 ` Krzysztof Kozlowski [this message]
2023-08-09 18:44 ` Alexander Stein
2023-08-10 6:11 ` Krzysztof Kozlowski
2023-08-10 7:32 ` Jerome Brunet
2023-08-10 7:46 ` Krzysztof Kozlowski
2023-08-10 7:51 ` Jerome Brunet
2023-08-21 17:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4462f00f-f590-df44-97d0-a657b3da2559@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@mailbox.org \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).