From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA05C433DB for ; Thu, 18 Feb 2021 15:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE2E764EAE for ; Thu, 18 Feb 2021 15:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbhBRPrb (ORCPT ); Thu, 18 Feb 2021 10:47:31 -0500 Received: from marcansoft.com ([212.63.210.85]:39040 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbhBRN13 (ORCPT ); Thu, 18 Feb 2021 08:27:29 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 5984A3FA55; Thu, 18 Feb 2021 13:24:58 +0000 (UTC) To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-18-marcan@marcan.st> <20210215180652.tbccd5dhsfjpdayp@kozik-lap> From: Hector Martin Subject: Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure Message-ID: <4475513e-ffe5-6064-d37e-8dbc16805dc7@marcan.st> Date: Thu, 18 Feb 2021 22:24:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210215180652.tbccd5dhsfjpdayp@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/02/2021 03.06, Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: >> +static void s3c64xx_serial_shutdown(struct uart_port *port) >> +{ >> + struct s3c24xx_uart_port *ourport = to_ourport(port); >> + >> + free_irq(port->irq, ourport); >> + >> + wr_regl(port, S3C64XX_UINTP, 0xf); >> + wr_regl(port, S3C64XX_UINTM, 0xf); >> + >> + ourport->tx_enabled = 0; >> + ourport->tx_mode = 0; >> + ourport->rx_enabled = 0; > > For S3C64xx type this is not equivalent: the assignments were > happening before free_irq() and wr_regl(). Honestly I don't know whether > it matters (except some barriers coming from these functions) but please > do not change the order of code in this patch. If needed, the > re-ordering should be a patch on its own. With explanation why. Honestly, I think if anything the masking should happen first (to make sure no IRQs go off), but at this point it's probably better to play it safe and not introduce any logic changes, so I've moved the assignments first to retain the old behavior. > Make the s3c24xx_serial_ops const as well. Done for v3, thanks. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub