From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: "Leonidas P. Papadakos"
<papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc
Date: Thu, 11 Apr 2019 14:10:35 +0200 [thread overview]
Message-ID: <4479415.7UHy68yjp9@phil> (raw)
In-Reply-To: <1554381609.12893.0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Am Donnerstag, 4. April 2019, 14:40:09 CEST schrieb Leonidas P. Papadakos:
>
> Should I make a patch v3 with the vccs for the emmc like on rock64?
> > vmmc-supply = <&vcc_io>;
> > vqmmc-supply = <&vcc18_emmc>;
>
> They do exist in the renegade dts.
modelling relevant supplies is always good to have.
I've applied your patch for 5.2 and just added the supplies you mention
above. So no need for a respin, but you could double-check that I didn't
mess up please:
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.2-armsoc/dts64&id=de674862f76d006c670308c46a010b3a09536fd3
Thanks
Heiko
next prev parent reply other threads:[~2019-04-11 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 11:23 [PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc Leonidas P. Papadakos
[not found] ` <20190404112329.8157-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-04 12:40 ` Leonidas P. Papadakos
[not found] ` <1554381609.12893.0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-11 12:10 ` Heiko Stuebner [this message]
2019-04-11 15:46 ` Leonidas P. Papadakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4479415.7UHy68yjp9@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).