Re: [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/04/2025 09:29, Xiangzhi Tang (唐相志) wrote:
> On Wed, 2025-04-02 at 13:16 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>


Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.


>>> +
>>> +     for_each_available_child_of_node(np, child) {
>>> +             if (of_device_is_compatible(child, "mediatek,vcp-
>>> core")) {
>>> +                     cpdev = of_find_device_by_node(child);
>>> +                     if (!cpdev) {
>>> +                             ret = -ENODEV;
>>> +                             dev_err(dev, "Not found platform
>>> device for core\n");
>>
>> You leak np, use scoped.
>> I'm not quite able to understand your meaning, Could you please
> explain it for me? Thanks very much.

Use proper quoting. Above makes no sense - you put your reply into my quote.

Explanation: You leak 'np'. Don't leak. Either drop reference or use
scoped loops. Look how every other driver does it. Read the API, read
the doc.

You ignored all other comments, so I assume you will implement them fully.

Best regards,
Krzysztof