From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD09C433EF for ; Tue, 14 Sep 2021 08:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C5F360F24 for ; Tue, 14 Sep 2021 08:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbhINIVm (ORCPT ); Tue, 14 Sep 2021 04:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbhINIVm (ORCPT ); Tue, 14 Sep 2021 04:21:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 295A0C061574 for ; Tue, 14 Sep 2021 01:20:25 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ3fz-00037F-Ds; Tue, 14 Sep 2021 10:20:23 +0200 Message-ID: <449f718706fd5af03190bdda986de37aa8fa14e3.camel@pengutronix.de> Subject: Re: [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: remove vqmmc-supply node From: Lucas Stach To: Heiko Thiery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Fabio Estevam , Shengjiu Wang , Joakim Zhang , Krzysztof Kozlowski , Michael Walle , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer Date: Tue, 14 Sep 2021 10:20:21 +0200 In-Reply-To: <20210914072627.24173-1-heiko.thiery@gmail.com> References: <20210914072627.24173-1-heiko.thiery@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, dem 14.09.2021 um 09:26 +0200 schrieb Heiko Thiery: > The sw4 output (V_1V8_S0 voltage) from the PMIC is the main supply for > the 1V8 power domain. It is not only used as supply for the eMMC. > So this voltage can not be changed and is not allowed to switched off. > Therefore we do not want to provide this regulator to the SDHC driver to > control this voltage. > This specific requirement should not be solved by removing the regulator connection from the SDHCI node, but instead by constraining the regulator voltage range to a fixed 3.3V and marking the regulator as always-on to reflect the hardware requirements in the DT. Also if your eMMC vqmmc is a fixed 3.3V, I don't think you need the faster pinctrl states, as you can't use the faster pin states anyways, as they require a 1.8V signaling voltage. Regards, Lucas > Fixes: 5dbadc848259 ("arm64: dts: fsl: add support for Kontron pitx-imx8m board") > Signed-off-by: Heiko Thiery > --- > > v2: > - slightly reword the commit message (thanks Michael) > - add Fixes tag (thanks Fabio) > > > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > index f593e4ff62e1..436d98135ba9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > @@ -348,7 +348,6 @@ &usdhc1 { > pinctrl-0 = <&pinctrl_usdhc1>; > pinctrl-1 = <&pinctrl_usdhc1_100mhz>; > pinctrl-2 = <&pinctrl_usdhc1_200mhz>; > - vqmmc-supply = <&sw4_reg>; > bus-width = <8>; > non-removable; > no-sd;