Re: [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/05/2025 07:25, Akhil R wrote:
> Specify the properties which are essential for the Tegra I2C driver to
> function correctly. Though all the existing DT nodes have these
> properties already, it was not mandated by the DT bindings.

I was rather expecting to see explanation why these were missing.

Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema")


> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> v2->v3:
>   * Updated commit description on the details and fixed indentation
>     issue.
> v1->v2:
>   * Added all required properties
> 
>  .../bindings/i2c/nvidia,tegra20-i2c.yaml      | 23 ++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> index b57ae6963e62..c1d38e6ff7d7 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> @@ -97,7 +97,9 @@ properties:
>  
>    resets:
>      items:
> -      - description: module reset
> +      - description: |

Do not need '|' unless you need to preserve formatting.


> +          Module reset. This property is optional for controllers in Tegra194 and later

Your binding says Tegra210 requires it, but 210 feels like something
later than 194. Maybe that's obvious for people knowing that device?

Anyway, please wrap at 80 (see kernel coding style).

> +          chips where an internal software reset is available as an alternative.
>  
>    reset-names:
>      items:
> @@ -116,6 +118,13 @@ properties:
>        - const: rx
>        - const: tx
>  
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names

dmas, dma-names, power-domains, see TXT binding... or extend commit
description why this should be different comparing to original binding.

Best regards,
Krzysztof