devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Eason Yen <eason.yen@mediatek.com>
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	devicetree@vger.kernel.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface
Date: Sun, 10 Nov 2019 21:18:38 +0100	[thread overview]
Message-ID: <44bddcd1-457d-bde6-791f-def248f787b3@gmail.com> (raw)
In-Reply-To: <1572247749-4276-2-git-send-email-eason.yen@mediatek.com>



On 28/10/2019 08:29, Eason Yen wrote:
> 1. Add a header file to provide SIP interface to ATF
> 2. Add AUDIO SMC fid
> 
> Change-Id: I218e9f571cea079268a5414725a81e9b35702e33

Please delete Change-Id entry.
Apart from that, I don't really get the reason for this patch. Which driver is
supposed to use this header file?

Please provide more background information.

Regards,
Matthias

> Signed-off-by: Eason Yen <eason.yen@mediatek.com>
> ---
>  include/linux/soc/mediatek/mtk_sip_svc.h |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h
> 
> diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h
> new file mode 100644
> index 0000000..00ee0f4
> --- /dev/null
> +++ b/include/linux/soc/mediatek/mtk_sip_svc.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2019 MediaTek Inc.
> + */
> +
> +#ifndef __MTK_SIP_SVC_H__
> +#define __MTK_SIP_SVC_H__
> +
> +#include <linux/kernel.h>
> +
> +/* Error Code */
> +#define SIP_SVC_E_SUCCESS               0
> +#define SIP_SVC_E_NOT_SUPPORTED         -1
> +#define SIP_SVC_E_INVALID_PARAMS        -2
> +#define SIP_SVC_E_INVALID_Range         -3
> +#define SIP_SVC_E_PERMISSION_DENY       -4
> +
> +#ifdef CONFIG_ARM64
> +#define MTK_SIP_SMC_AARCH_BIT			0x40000000
> +#else
> +#define MTK_SIP_SMC_AARCH_BIT			0x00000000
> +#endif
> +
> +/* AUDIO related SMC call */
> +#define MTK_SIP_AUDIO_CONTROL \
> +	(0x82000517 | MTK_SIP_SMC_AARCH_BIT)
> +#endif
> +/* __MTK_SIP_SVC_H__ */
> 

  reply	other threads:[~2019-11-10 20:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  7:29 [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface Eason Yen
2019-10-28  7:29 ` Eason Yen
2019-11-10 20:18   ` Matthias Brugger [this message]
2019-11-11  1:38     ` Eason Yen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44bddcd1-457d-bde6-791f-def248f787b3@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eason.yen@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).