Re: [PATCH v3 06/13] arm64: dts: mediatek: mt7988: add basic ethernet-nodes

Andrew Lunn
2025-06-08T21:23:44Z

> + gmac0: mac@0 {
> + compatible = "mediatek,eth-mac";
> + reg = <0>;
> + phy-mode = "internal";
> +
> + fixed-link {
> + speed = <10000>;
> + full-duplex;
> + pause;
> + };

Maybe i've asked this before? What is on the other end of this link?
phy-mode internal and fixed link seems an odd combination. It might
just need some comments, if this is internally connected to a switch.

> + mdio_bus: mdio-bus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* internal 2.5G PHY */
> + int_2p5g_phy: ethernet-phy@f {
> + reg = <15>;

It is a bit odd mixing hex and decimal.

> + compatible = "ethernet-phy-ieee802.3-c45";

I _think_ the coding standard say the compatible should be first.

> + phy-mode = "internal";

A phy should not have a phy-mode.

Andrew