From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5220FC7618E for ; Fri, 21 Apr 2023 16:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232255AbjDUQau (ORCPT ); Fri, 21 Apr 2023 12:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbjDUQat (ORCPT ); Fri, 21 Apr 2023 12:30:49 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F25D71447E for ; Fri, 21 Apr 2023 09:30:46 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5066ce4f490so2754665a12.2 for ; Fri, 21 Apr 2023 09:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682094645; x=1684686645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UVr8lLzVps9ZuMV0XAHw4eg8z7YXbZGCdlhpUNWCutQ=; b=DwM7MXIKKSfaUMu1eJSCloBjXJpaWHmzbVeI7uMDb7pgL26Yroz/mrZnf+4gtrdE32 zExJo/fxP73tyLq655HHLTKrCsFatO34nBhRbfiVIMhlyj/+r8Eh8yx8N2ZaXNRi8oAF IW2kt7uZzpCSSmxDo54dDanjtAMdz0KucVKX6OLZf8iP/KTVxB496RNWBL2q4r+SmEK5 TcvtGvBBuW919Awdq2NozfHd2fEMp7na72TSuKyqiu8JdDpk42iHW1YO+ljs8J15VAIg TtU2RWkt0B0KOfnYkux1+LEVI3q2cepzBD1Brn1hT4Qa/4hYdAaJ1ygI60RyEZLy3GtJ aCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682094645; x=1684686645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UVr8lLzVps9ZuMV0XAHw4eg8z7YXbZGCdlhpUNWCutQ=; b=WfOHACKs5Z6vP/B8bjRfVpWzhq8qdFzPjrAr3hDU9rjMw4XLdTpD95rU6muPOGaB37 S5CKFG0ir9y236+Z8ftWJcHffliSNy3ZrT7hgEjRG3RPn1YGNOS03RZJtuvMCVMJHR/s eFcguYRP8k0KTMxudxdhp+k/z4hf7wRJQfcwJ/LUQHETTvFH49o1mXmjK9+I5XvHWxli r9iE/jgaMgS+l6wbrNMDv+0D0LloFPlkWTFs62ZO6R9pG1RIDdYlWp01pYneiplPKAiE VbEK7WORnasL5SYQIwLjnuzSnoqMcFZ1D0IB9H06K1hX6X+nV+krn6B2pTjaSkdB5f20 QsvA== X-Gm-Message-State: AAQBX9cohYPXr5nbGi3khtfIvOJ3ErNjL1bAVHMJ1hfGjTfQDUHDBmFa Oi6mM2EglZD6O1kDg5oo8E1cDKb7Y5FqYiXXW21zrw== X-Google-Smtp-Source: AKy350aa+VFT9KWufyYZvoi2qVl9Wo73hJiODISOMGd6i4if1G9OIE1Qj4FNQLJhsvAngpdIWqI+Pg== X-Received: by 2002:aa7:c592:0:b0:506:c288:118 with SMTP id g18-20020aa7c592000000b00506c2880118mr5598942edq.39.1682094645408; Fri, 21 Apr 2023 09:30:45 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:687d:8c5:41cb:9883? ([2a02:810d:15c0:828:687d:8c5:41cb:9883]) by smtp.gmail.com with ESMTPSA id d12-20020a50fb0c000000b004bf999f8e57sm1963884edq.19.2023.04.21.09.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 09:30:44 -0700 (PDT) Message-ID: <44e54d54-9a6d-ba49-c0db-f9de81743f64@linaro.org> Date: Fri, 21 Apr 2023 18:30:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 06/11] dt-bindings: PCI: Update the RK3399 example to a valid one Content-Language: en-US To: Lorenzo Pieralisi Cc: Rick Wertenbroek , alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, dlemoal@kernel.org, Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Caleb Connolly , Corentin Labbe , Brian Norris , Johan Jonker , Judy Hsiao , Sascha Hauer , Hugh Cole-Baker , Arnaud Ferraris , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230418074700.1083505-1-rick.wertenbroek@gmail.com> <20230418074700.1083505-7-rick.wertenbroek@gmail.com> <172c46b7-256e-b09d-3940-880fa8989b49@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/04/2023 11:26, Lorenzo Pieralisi wrote: > On Wed, Apr 19, 2023 at 10:01:25PM +0200, Krzysztof Kozlowski wrote: >> On 18/04/2023 09:46, Rick Wertenbroek wrote: >>> Update the example in the documentation to a valid example. >>> Address for mem-base was invalid, it pointed to address >>> 0x8000'0000 which is the upper region of the DDR which >>> is not necessarily populated depending on the board. >>> This address should point to the base of the memory >>> window region of the controller which is 0xfa00'0000. >>> Add missing pinctrl. >>> >>> Signed-off-by: Rick Wertenbroek >>> --- >>> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> index 88386a6d7011..6b62f6f58efe 100644 >>> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> @@ -47,7 +47,7 @@ examples: >>> >>> pcie-ep@f8000000 { >>> compatible = "rockchip,rk3399-pcie-ep"; >>> - reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>; >>> + reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>; >>> reg-names = "apb-base", "mem-base"; >>> clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>, >>> <&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>; >>> @@ -63,6 +63,8 @@ examples: >>> phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>; >>> phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3"; >>> rockchip,max-outbound-regions = <16>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pcie_clkreqnb_cpm>; >> >> This is just example of the binding, you do not need to fill all >> unrelated (generic) properties like pinctrl. > > Should I merge it as-is ? Yeah, go ahead. That was the note for the future that generic properties are not always needed or even helpful in the example. Best regards, Krzysztof