Re: [PATCH v6 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode

[Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>]

On 7/21/2026 12:19 PM, Krzysztof Kozlowski wrote:
> On Mon, Jul 20, 2026 at 10:02:39PM +0530, Mohammad Rafi Shaik wrote:
>>
>>
>> On 7/20/2026 9:40 PM, sashiko-bot@kernel.org wrote:
>>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>>> - [Medium] Contradictory array lengths and definitions between `clocks` and `clock-names`, making valid hardware clock combinations fail validation.
>>> --
>>>
>>> --- Patch [1]: [PATCH v6 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode ---
>>> commit cca2bfa9278ee0dba4fe02f999f9bda9ec6f258f
>>> Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>>> ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode
>>>
>>> This commit extends the qcom,q6apm-lpass-dais device tree binding to explicitly
>>> describe Digital Audio Interface (DAI) child nodes. It adds address and size
>>> cells to allow multiple DAI instances and defines a pattern to document per-DAI
>>> properties like interface IDs and clocks.
>>>
>>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
>>>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
>>>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
>>> [ ... ]
>>>> +      clocks:
>>>> +        minItems: 1
>>>> +        items:
>>>> +          - description: MI2S bit clock
>>>> +          - description: MI2S external bit clock
>>>> +          - description: MI2S master clock
>>>> +
>>>> +      clock-names:
>>>> +        minItems: 1
>>>> +        items:
>>>> +          - enum: [bclk, eclk, mclk]
>>>> +          - const: mclk
>>>
>>> [Severity: Medium]
>>> Will this cause device tree validation to fail for valid hardware clock
>>> combinations?
>>>
>>> The clocks list defines 3 items, but clock-names defines only 2 items.
>>> Because dt-schema limits arrays to the size of the items list when defined
>>> in this way, providing 3 clocks in a device tree will trigger a "too long"
>>> array error for clock-names.
>>>
>>> Additionally, do the array index descriptions mismatch? The clocks array
>>> defines index 1 as the external bit clock, but clock-names index 1 strictly
>>> requires "mclk". This would prevent configuring "bclk" and "eclk" together
>>> if "mclk" is not present.
>>
>>
>> The sashiko review assumes that bclk and eclk may be used together.
>>
>> However, the hardware supports either bclk or eclk, optionally with mclk. A
>> bclk + eclk configuration is not valid hardware usage,so the reported issue
>> is not applicable to the valid clock configurations.
> 
> But you wrote that eclk ALWAYS follows bclk! Look!
> 
> +        items:
> +          - description: MI2S bit clock
> +          - description: MI2S external bit clock
> 
> What is the meaning of this?

your right, The item descriptions are misleading because they imply an 
ordered bclk + eclk configuration. I'll drop those descriptions.

The hardware supports either bclk or eclk.

will keep only

clocks:
   minItems: 1
   maxItems: 2


Thanks & Regards,
Rafi.

> 



> Best regards,
> Krzysztof
>