* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-19 15:29 [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions Olliver Schinagl
@ 2022-08-23 10:33 ` Krzysztof Kozlowski
2022-08-29 14:12 ` Alexander Dahl
2022-08-30 10:28 ` Jacek Anaszewski
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-23 10:33 UTC (permalink / raw)
To: Olliver Schinagl, Rob Herring, Krzysztof Kozlowski
Cc: Jacek Anaszewski, Baolin Wang, Daniel Mack, Linus Walleij,
Oleh Kravchenko, Sakari Ailus, Simon Shields, Olliver Schinagl,
devicetree, linux-kernel
On 19/08/2022 18:29, Olliver Schinagl wrote:
> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> added. However, there's a little more very common LED colors.
>
> While the documentation states 'add what is missing', engineers tend to
> be lazy and will just use what currently exists. So this patch will take
> (a) list from online retailers [0], [1], [2] and use the common LED colors
> from there, this being reasonable as this is what is currently available to
> purchase.
>
> Note, that LIME seems to be the modern take to 'Yellow-green' or
> 'Yellowish-green' from some older datasheets.
>
> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-19 15:29 [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions Olliver Schinagl
2022-08-23 10:33 ` Krzysztof Kozlowski
@ 2022-08-29 14:12 ` Alexander Dahl
2022-08-29 15:13 ` Rob Herring
2022-08-30 10:28 ` Jacek Anaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Alexander Dahl @ 2022-08-29 14:12 UTC (permalink / raw)
To: Olliver Schinagl
Cc: Rob Herring, Krzysztof Kozlowski, Jacek Anaszewski, Baolin Wang,
Daniel Mack, Linus Walleij, Oleh Kravchenko, Sakari Ailus,
Simon Shields, Olliver Schinagl, devicetree, linux-kernel
Hei Olliver,
Am Fri, Aug 19, 2022 at 05:29:04PM +0200 schrieb Olliver Schinagl:
> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> added. However, there's a little more very common LED colors.
>
> While the documentation states 'add what is missing', engineers tend to
> be lazy and will just use what currently exists. So this patch will take
> (a) list from online retailers [0], [1], [2] and use the common LED colors
> from there, this being reasonable as this is what is currently available to
> purchase.
>
> Note, that LIME seems to be the modern take to 'Yellow-green' or
> 'Yellowish-green' from some older datasheets.
Just noticed you did not send this to neither linux-leds mailing list
nor the LED subsystem maintainer. Maybe you want to do this in v3?
Greets
Alex
>
> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
>
> Changes since v1: Unbreak existing definitions.
>
>
> include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 3be89a7c20a9..04bf94523ea3 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -22,18 +22,22 @@
> #define LEDS_BOOST_FIXED 2
>
> /* Standard LED colors */
> -#define LED_COLOR_ID_WHITE 0
> -#define LED_COLOR_ID_RED 1
> -#define LED_COLOR_ID_GREEN 2
> -#define LED_COLOR_ID_BLUE 3
> -#define LED_COLOR_ID_AMBER 4
> -#define LED_COLOR_ID_VIOLET 5
> -#define LED_COLOR_ID_YELLOW 6
> -#define LED_COLOR_ID_IR 7
> -#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> -#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
> - so this would include RGBW and similar */
> -#define LED_COLOR_ID_MAX 10
> +#define LED_COLOR_ID_WHITE 0
> +#define LED_COLOR_ID_RED 1
> +#define LED_COLOR_ID_GREEN 2
> +#define LED_COLOR_ID_BLUE 3
> +#define LED_COLOR_ID_AMBER 4
> +#define LED_COLOR_ID_VIOLET 5
> +#define LED_COLOR_ID_YELLOW 6
> +#define LED_COLOR_ID_IR 7
> +#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> +#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, including RGBW etc. */
> +#define LED_COLOR_ID_PUPRPLE 10
> +#define LED_COLOR_ID_ORANGE 11
> +#define LED_COLOR_ID_PINK 12
> +#define LED_COLOR_ID_CYAN 13
> +#define LED_COLOR_ID_LIME 14
> +#define LED_COLOR_ID_MAX 15
>
> /* Standard LED functions */
> /* Keyboard LEDs, usually it would be input4::capslock etc. */
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-29 14:12 ` Alexander Dahl
@ 2022-08-29 15:13 ` Rob Herring
2022-08-30 8:30 ` Olliver Schinagl
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-08-29 15:13 UTC (permalink / raw)
To: Olliver Schinagl, Krzysztof Kozlowski, Jacek Anaszewski,
Baolin Wang, Daniel Mack, Linus Walleij, Oleh Kravchenko,
Sakari Ailus, Simon Shields, Olliver Schinagl, devicetree,
linux-kernel
On Mon, Aug 29, 2022 at 04:12:00PM +0200, Alexander Dahl wrote:
> Hei Olliver,
>
> Am Fri, Aug 19, 2022 at 05:29:04PM +0200 schrieb Olliver Schinagl:
> > In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> > Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> > added. However, there's a little more very common LED colors.
> >
> > While the documentation states 'add what is missing', engineers tend to
> > be lazy and will just use what currently exists. So this patch will take
> > (a) list from online retailers [0], [1], [2] and use the common LED colors
> > from there, this being reasonable as this is what is currently available to
> > purchase.
> >
> > Note, that LIME seems to be the modern take to 'Yellow-green' or
> > 'Yellowish-green' from some older datasheets.
>
> Just noticed you did not send this to neither linux-leds mailing list
> nor the LED subsystem maintainer. Maybe you want to do this in v3?
Yes, please do. If Pavel doesn't pick up v3 in a timely manor, then I
will.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-29 15:13 ` Rob Herring
@ 2022-08-30 8:30 ` Olliver Schinagl
2022-08-30 8:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Olliver Schinagl @ 2022-08-30 8:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Jacek Anaszewski, Baolin Wang,
Daniel Mack, Linus Walleij, Oleh Kravchenko, Sakari Ailus,
Simon Shields, Olliver Schinagl, devicetree, linux-kernel
Hey all,
On 29-08-2022 17:13, Rob Herring wrote:
> On Mon, Aug 29, 2022 at 04:12:00PM +0200, Alexander Dahl wrote:
>> Hei Olliver,
>>
>> Am Fri, Aug 19, 2022 at 05:29:04PM +0200 schrieb Olliver Schinagl:
>>> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
>>> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
>>> added. However, there's a little more very common LED colors.
>>>
>>> While the documentation states 'add what is missing', engineers tend to
>>> be lazy and will just use what currently exists. So this patch will take
>>> (a) list from online retailers [0], [1], [2] and use the common LED colors
>>> from there, this being reasonable as this is what is currently available to
>>> purchase.
>>>
>>> Note, that LIME seems to be the modern take to 'Yellow-green' or
>>> 'Yellowish-green' from some older datasheets.
>> Just noticed you did not send this to neither linux-leds mailing list
>> nor the LED subsystem maintainer. Maybe you want to do this in v3?
> Yes, please do. If Pavel doesn't pick up v3 in a timely manor, then I
> will.
>
> Rob
Sorry to both, get_maintainers didn't pop those up!
As Krzyzstof Acked the v2, and no comments for a v3 have been proposed,
would that be a changeless v3 just to involve all parties?
Thanks,
Olliver
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-30 8:30 ` Olliver Schinagl
@ 2022-08-30 8:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 8:37 UTC (permalink / raw)
To: Olliver Schinagl, Rob Herring, Krzysztof Kozlowski,
Jacek Anaszewski, Baolin Wang, Daniel Mack, Linus Walleij,
Oleh Kravchenko, Sakari Ailus, Simon Shields, Olliver Schinagl,
devicetree, linux-kernel
On 30/08/2022 11:30, Olliver Schinagl wrote:
> Hey all,
>
> On 29-08-2022 17:13, Rob Herring wrote:
>> On Mon, Aug 29, 2022 at 04:12:00PM +0200, Alexander Dahl wrote:
>>> Hei Olliver,
>>>
>>> Am Fri, Aug 19, 2022 at 05:29:04PM +0200 schrieb Olliver Schinagl:
>>>> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
>>>> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
>>>> added. However, there's a little more very common LED colors.
>>>>
>>>> While the documentation states 'add what is missing', engineers tend to
>>>> be lazy and will just use what currently exists. So this patch will take
>>>> (a) list from online retailers [0], [1], [2] and use the common LED colors
>>>> from there, this being reasonable as this is what is currently available to
>>>> purchase.
>>>>
>>>> Note, that LIME seems to be the modern take to 'Yellow-green' or
>>>> 'Yellowish-green' from some older datasheets.
>>> Just noticed you did not send this to neither linux-leds mailing list
>>> nor the LED subsystem maintainer. Maybe you want to do this in v3?
>> Yes, please do. If Pavel doesn't pick up v3 in a timely manor, then I
>> will.
>>
>> Rob
>
> Sorry to both, get_maintainers didn't pop those up!
Indeed, I sent a fix for this.
>
> As Krzyzstof Acked the v2, and no comments for a v3 have been proposed,
> would that be a changeless v3 just to involve all parties?
Yeah, just resend with get_maintainers output based on
Documentation/devicetree/bindings/leds/ (or on top of my patch).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-19 15:29 [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions Olliver Schinagl
2022-08-23 10:33 ` Krzysztof Kozlowski
2022-08-29 14:12 ` Alexander Dahl
@ 2022-08-30 10:28 ` Jacek Anaszewski
2022-08-30 13:40 ` Olliver Schinagl
2 siblings, 1 reply; 8+ messages in thread
From: Jacek Anaszewski @ 2022-08-30 10:28 UTC (permalink / raw)
To: Olliver Schinagl, Rob Herring, Krzysztof Kozlowski
Cc: Baolin Wang, Daniel Mack, Linus Walleij, Oleh Kravchenko,
Sakari Ailus, Simon Shields, Olliver Schinagl, devicetree,
linux-kernel
Hi Oliver,
On 8/19/22 17:29, Olliver Schinagl wrote:
> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> added. However, there's a little more very common LED colors.
>
> While the documentation states 'add what is missing', engineers tend to
> be lazy and will just use what currently exists. So this patch will take
> (a) list from online retailers [0], [1], [2] and use the common LED colors
> from there, this being reasonable as this is what is currently available to
> purchase.
>
> Note, that LIME seems to be the modern take to 'Yellow-green' or
> 'Yellowish-green' from some older datasheets.
>
> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
>
> Changes since v1: Unbreak existing definitions.
>
>
> include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 3be89a7c20a9..04bf94523ea3 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -22,18 +22,22 @@
> #define LEDS_BOOST_FIXED 2
>
> /* Standard LED colors */
> -#define LED_COLOR_ID_WHITE 0
> -#define LED_COLOR_ID_RED 1
> -#define LED_COLOR_ID_GREEN 2
> -#define LED_COLOR_ID_BLUE 3
> -#define LED_COLOR_ID_AMBER 4
> -#define LED_COLOR_ID_VIOLET 5
> -#define LED_COLOR_ID_YELLOW 6
> -#define LED_COLOR_ID_IR 7
> -#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> -#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
> - so this would include RGBW and similar */
> -#define LED_COLOR_ID_MAX 10
> +#define LED_COLOR_ID_WHITE 0
> +#define LED_COLOR_ID_RED 1
> +#define LED_COLOR_ID_GREEN 2
> +#define LED_COLOR_ID_BLUE 3
> +#define LED_COLOR_ID_AMBER 4
> +#define LED_COLOR_ID_VIOLET 5
> +#define LED_COLOR_ID_YELLOW 6
> +#define LED_COLOR_ID_IR 7
> +#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> +#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, including RGBW etc. */
> +#define LED_COLOR_ID_PUPRPLE 10
typo - as already mentioned
> +#define LED_COLOR_ID_ORANGE 11
> +#define LED_COLOR_ID_PINK 12
> +#define LED_COLOR_ID_CYAN 13
> +#define LED_COLOR_ID_LIME 14
> +#define LED_COLOR_ID_MAX 15
>
> /* Standard LED functions */
> /* Keyboard LEDs, usually it would be input4::capslock etc. */
And it seems that change in spacing between definition name and value
is not required, is it? Without that change, it would be easier to
notice what really changes here.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv2 resend] dt-bindings: leds: Expand LED_COLOR_ID definitions
2022-08-30 10:28 ` Jacek Anaszewski
@ 2022-08-30 13:40 ` Olliver Schinagl
0 siblings, 0 replies; 8+ messages in thread
From: Olliver Schinagl @ 2022-08-30 13:40 UTC (permalink / raw)
To: Jacek Anaszewski, Rob Herring, Krzysztof Kozlowski
Cc: Baolin Wang, Daniel Mack, Linus Walleij, Oleh Kravchenko,
Sakari Ailus, Simon Shields, Olliver Schinagl, devicetree,
linux-kernel
On 30-08-2022 12:28, Jacek Anaszewski wrote:
> Hi Oliver,
>
> On 8/19/22 17:29, Olliver Schinagl wrote:
>> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
>> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
>> added. However, there's a little more very common LED colors.
>>
>> While the documentation states 'add what is missing', engineers tend to
>> be lazy and will just use what currently exists. So this patch will take
>> (a) list from online retailers [0], [1], [2] and use the common LED colors
>> from there, this being reasonable as this is what is currently available to
>> purchase.
>>
>> Note, that LIME seems to be the modern take to 'Yellow-green' or
>> 'Yellowish-green' from some older datasheets.
>>
>> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
>> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
>> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
>>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
>> ---
>>
>> Changes since v1: Unbreak existing definitions.
>>
>>
>> include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
>> index 3be89a7c20a9..04bf94523ea3 100644
>> --- a/include/dt-bindings/leds/common.h
>> +++ b/include/dt-bindings/leds/common.h
>> @@ -22,18 +22,22 @@
>> #define LEDS_BOOST_FIXED 2
>>
>> /* Standard LED colors */
>> -#define LED_COLOR_ID_WHITE 0
>> -#define LED_COLOR_ID_RED 1
>> -#define LED_COLOR_ID_GREEN 2
>> -#define LED_COLOR_ID_BLUE 3
>> -#define LED_COLOR_ID_AMBER 4
>> -#define LED_COLOR_ID_VIOLET 5
>> -#define LED_COLOR_ID_YELLOW 6
>> -#define LED_COLOR_ID_IR 7
>> -#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
>> -#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
>> - so this would include RGBW and similar */
>> -#define LED_COLOR_ID_MAX 10
>> +#define LED_COLOR_ID_WHITE 0
>> +#define LED_COLOR_ID_RED 1
>> +#define LED_COLOR_ID_GREEN 2
>> +#define LED_COLOR_ID_BLUE 3
>> +#define LED_COLOR_ID_AMBER 4
>> +#define LED_COLOR_ID_VIOLET 5
>> +#define LED_COLOR_ID_YELLOW 6
>> +#define LED_COLOR_ID_IR 7
>> +#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
>> +#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, including RGBW etc. */
>> +#define LED_COLOR_ID_PUPRPLE 10
> typo - as already mentioned
Sorry, I did not receive your earlier mail it seems, or it's not showing
up in the thread; well caught!
>
>> +#define LED_COLOR_ID_ORANGE 11
>> +#define LED_COLOR_ID_PINK 12
>> +#define LED_COLOR_ID_CYAN 13
>> +#define LED_COLOR_ID_LIME 14
>> +#define LED_COLOR_ID_MAX 15
>>
>> /* Standard LED functions */
>> /* Keyboard LEDs, usually it would be input4::capslock etc. */
> And it seems that change in spacing between definition name and value
> is not required, is it? Without that change, it would be easier to
> notice what really changes here.
>
Yes, you are correct, I initially had LimeGreen there, which made it
longer, as I later found out, that LimeGreen could actually just be Lime
as much, I forgot to 're-shorten it. The fixed diff for v4 does look as
expected! thanks for that one.
^ permalink raw reply [flat|nested] 8+ messages in thread