devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp
Date: Thu, 8 Dec 2022 14:25:42 +0100	[thread overview]
Message-ID: <44f24d39-d593-0da4-d9d3-2e0cf283b6ca@denx.de> (raw)
In-Reply-To: <2861512.e9J7NaK4W3@steina-w>

On 12/8/22 07:31, Alexander Stein wrote:
> Hello Marek,
> 
> Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut:
>> On 12/7/22 16:13, Alexander Stein wrote:
>>> i.MX8MP uses 3 clocks, so soften the restrictions for clocks &
>>> clock-names.
>>>
>>> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP")
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>>    Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++-
>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 876015a44a1e6..793e8eccf8b8b 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -70,7 +70,9 @@ allOf:
>>>          properties:
>>>            compatible:
>>>              contains:
>>> -            const: fsl,imx6sx-lcdif
>>> +            enum:
>>> +              - fsl,imx6sx-lcdif
>>> +              - fsl,imx8mp-lcdif
>>>
>>>        then:
>>>          properties:
>>>            clocks:
>> Reviewed-by: Marek Vasut <marex@denx.de>
> 
> Thanks!
> 
>> btw you might want to update the clock-names and clock proerty order in
>> imx8mp.dtsi to match the clock-names order in these bindings.
> 
> The lcdif nodes are not yet in linux-next ;-) So its probably a local commit
> on your side. But yes, the upcoming patches will address this.

Ah, right, seems they are still pending HDMI and DSIM addition. Sorry 
for the noise.

  reply	other threads:[~2022-12-08 13:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 15:13 [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Alexander Stein
2022-12-07 15:14 ` [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain Alexander Stein
2022-12-07 16:00   ` Marek Vasut
2022-12-08  5:59     ` Alexander Stein
2022-12-08  8:25       ` Krzysztof Kozlowski
2022-12-08  8:50         ` Alexander Stein
2022-12-08  8:57           ` Krzysztof Kozlowski
2022-12-07 17:44   ` Rob Herring
2022-12-07 15:59 ` [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Marek Vasut
2022-12-08  6:31   ` Alexander Stein
2022-12-08 13:25     ` Marek Vasut [this message]
2022-12-07 17:44 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44f24d39-d593-0da4-d9d3-2e0cf283b6ca@denx.de \
    --to=marex@denx.de \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).