From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Archit Taneja <architt@codeaurora.org>,
linux-arm-msm@vger.kernel.org, robh@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings
Date: Tue, 06 Dec 2016 18:08:55 +0200 [thread overview]
Message-ID: <4504382.pqKQWZshtj@avalon> (raw)
In-Reply-To: <20161206132020.uzchq63pfpaujg6h@sirena.org.uk>
Hi Mark,
On Tuesday 06 Dec 2016 13:20:20 Mark Brown wrote:
> On Tue, Dec 06, 2016 at 02:46:55PM +0200, Laurent Pinchart wrote:
> > On Tuesday 06 Dec 2016 10:05:17 Mark Brown wrote:
> > > On Mon, Dec 05, 2016 at 11:16:22PM +0200, Laurent Pinchart wrote:
> > > > This has been discussed previously, and Rob agreed that if the
> > > > datasheet recommends to power all supplies from the same regulator we
> > > > can take that as a good hint that a single supply should be enough. In
> > > > the very
> > >
> > > No, don't do this - introducing special snowflake bindings just makes
> > > things more complex at the system level and tells everyone else that
> > > they too can have special snowflake bindings. Someone should be able to
> > > connect up the regulators based purely on a schematic. Just describe
> > > the hardware, it's just one extra line in the DT per regulator.
> >
> > There are power supply pin that have different names but documented as
> > having to be connected to the same supply. I really see no point in
> > having multiple regulators for them.
>
> The tiny amount of extra typing involved doesn't seem like much of a
> cost for keeping things consistent with every other regulator user out
> there.
I'm not concerned by that at all, but by the additional runtime complexity :-/
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-12-06 16:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1472640730-24326-1-git-send-email-architt@codeaurora.org>
[not found] ` <1472640730-24326-1-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-31 10:52 ` [PATCH 1/3] dt-bindings: drm/bridge: adv7511: Add regulators for ADV7533 Archit Taneja
2016-09-02 15:56 ` Rob Herring
2016-09-06 4:22 ` Archit Taneja
[not found] ` <1474622430-6704-1-git-send-email-architt@codeaurora.org>
2016-09-23 9:20 ` [PATCH v2 1/4] dt-bindings: drm/bridge: adv7511: Add regulator bindings Archit Taneja
2016-09-23 22:31 ` Rob Herring
[not found] ` <1474622430-6704-2-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-25 17:28 ` Laurent Pinchart
2016-09-26 6:40 ` Archit Taneja
2016-09-26 8:12 ` Laurent Pinchart
2016-10-14 5:40 ` Archit Taneja
2016-11-10 1:34 ` Rob Herring
[not found] ` <CAL_Jsq+KMPoyWvh1U3OKL6pX8D4QByqVFgcMks8myDfZEYeFCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-15 3:35 ` Archit Taneja
[not found] ` <1480399662-8858-1-git-send-email-architt@codeaurora.org>
[not found] ` <1480399662-8858-1-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-29 6:07 ` [PATCH v3 1/2] " Archit Taneja
[not found] ` <1480399662-8858-2-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-29 6:33 ` Laurent Pinchart
2016-11-29 8:11 ` Archit Taneja
2016-11-29 9:11 ` Laurent Pinchart
2016-11-29 11:01 ` Mark Brown
2016-11-29 19:37 ` Laurent Pinchart
2016-11-30 16:14 ` Mark Brown
2016-12-05 21:11 ` Bjorn Andersson
2016-12-05 21:16 ` Laurent Pinchart
2016-12-06 10:05 ` Mark Brown
2016-12-06 12:46 ` Laurent Pinchart
2016-12-06 13:20 ` Mark Brown
2016-12-06 16:08 ` Laurent Pinchart [this message]
2016-12-06 16:11 ` Mark Brown
[not found] ` <1480924435-20882-1-git-send-email-architt@codeaurora.org>
2016-12-05 7:53 ` [PATCH v4 " Archit Taneja
2016-12-09 22:11 ` Rob Herring
2016-12-18 11:17 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4504382.pqKQWZshtj@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).