Re: [PATCH] arm64: zynqmp: Switch to amd.com emails

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 16/05/2023 19:20, Michal Simek wrote:
> 
> 
> On 5/16/23 18:05, Krzysztof Kozlowski wrote:
>> On 16/05/2023 15:41, Michal Simek wrote:
>>> Update my and DPs email address to match current setup.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>> ---
>>>
>>>   arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dts      | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi         | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-sck-kv-g-revA.dtso   | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-sck-kv-g-revB.dtso   | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts      | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dts     | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dts      | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dts      | 7 ++++---
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dts | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dts | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dts | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dts | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dts | 7 ++++---
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts    | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dts    | 5 +++--
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts      | 2 +-
>>>   arch/arm64/boot/dts/xilinx/zynqmp-zcu1275-revA.dts     | 7 ++++---
>>>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi                 | 5 +++--
>>>   24 files changed, 51 insertions(+), 39 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dts b/arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dts
>>> index 88aa06fa78a8..1495272e5668 100644
>>> --- a/arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dts
>>> +++ b/arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dts
>>> @@ -2,9 +2,10 @@
>>>   /*
>>>    * dts file for Avnet Ultra96 rev1
>>>    *
>>> - * (C) Copyright 2018, Xilinx, Inc.
>>> + * (C) Copyright 2018 - 2022, Xilinx, Inc.
>>> + * (C) Copyright 2022 - 2023, Advanced Micro Devices, Inc.
>>
>> I think these should be split. Your commit suggests only update to email
>> but you add copyrights. While email change is trivial, 
> 
> ok
> 
>> the copyright
>> change is not (at least not for everyone and for every legal system).
>>
>> What's more, there were no changes to this file after 2018. What
>> copyrighted work did you add in 2019, 2020, 2021, 2022 and 2023? For
>> this file clear: NAK
> 
> All these files are regularly updated in soc vendor tree. I can do stats to 
> double check every file but I am quite sure that every year we did touch these 
> files at least with single line of change (and not just copyright update).

I checked. Copyrights, if you need them, should be added in a meaningful
way, so with copyrightable work. This file has 0.

For other files, if you want to add copyrights for every trivial change,
this will lead to adding other people's copyrights as well...

> It means at least it is not big concern from me that we created file in 2018 and 
> then touch them this year.
> The question is if this is valid argument which could be accepted upstream.
> TBH I don't mind too much because primary reason for this patch was updating my 
> email address.
> 


Best regards,
Krzysztof