From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79382C4332F for ; Mon, 12 Dec 2022 09:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbiLLJQZ (ORCPT ); Mon, 12 Dec 2022 04:16:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231805AbiLLJP5 (ORCPT ); Mon, 12 Dec 2022 04:15:57 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03EE6E0C0 for ; Mon, 12 Dec 2022 01:15:55 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id f20so11838288lja.4 for ; Mon, 12 Dec 2022 01:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3i8DxZYukDlFANivRrDcpJlJ1yInWzN03lkuTs3FHs0=; b=FkaasSlxJvIZIdRZa5WYAeHRkTMVNEfuyD/Tymm3CmuhnwfbgxtwLhAFF56ItxzmS3 yNNpcWNoznIYFiHqCzf5Xg+LF7y1ViCrmKzUkla+a8KcpltCQRXAH0/ENEDSE4o+WFeX 8HXRLl/WjiZvWB6FfAfPBs/2qLU5oLwplrDNC9BQnPhFTEclgePVkmoZYHWoYRGYQbfD AG51XJ2jDoxahwPP+kVCbjSArv/ib87McVYVHfy+Wze03lXpnEABiLsm/m94bATv677h VCjux1hOvqZU88y5Pc+BQ477MQT3vOwjsc3wr1xgcVms8gMpQIK3/gJbfSpRmsPd+Osj 3Atg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3i8DxZYukDlFANivRrDcpJlJ1yInWzN03lkuTs3FHs0=; b=BuXwff99/Sy1x5SPJd0tGkjblzDxNffCc90QzuQ6RvfTCqmMscjTz6DoTSd1oKAQeP opd9sCO56aTHKy0tjSHSMR1cQtLcq1+FxhOaNA4W+nJddDeXeLEkJisKCaB0ZoDGYQBU b6qd4Sw9/BhSUjc7IIVEEfJtCladdP1K6SzaFGtX0GO5HAKxc5pJVvWDlpSEvb06mmVG ViWjjz1DbEe73FpdRmTzBDu6LEmoh7E92PfyLwUNTlw21X6VKpzsEqEi6dQPEj7wA+V1 Kkc+C17R4xhNXviFJcOj5Xfins6znXYxSQ/pOYsprdK1SjKZ1+iHCWYrEQcKAIXdTRnd GZog== X-Gm-Message-State: ANoB5pmPRgqeKOVZVfYSuasGKT3WeUw+QFb2MYcQnSEewGfoMLfNfkFf IxYTjEBUSZTaMJ+6tKM2ae7FdBTKARjJjLpy X-Google-Smtp-Source: AA0mqf4+LREp008KNa6o91TXG5e7yPmbpxuO8UZ+w1ay0Mp6aoyKqEWJoqXDRC5BAUg7SuYD44hZOw== X-Received: by 2002:a2e:be8c:0:b0:278:e872:cade with SMTP id a12-20020a2ebe8c000000b00278e872cademr4681270ljr.39.1670836553299; Mon, 12 Dec 2022 01:15:53 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id t18-20020a2e8e72000000b002778a76a3c3sm1135404ljk.112.2022.12.12.01.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 01:15:52 -0800 (PST) Message-ID: <4522aa1d-99fd-66ad-70bb-d39d9f5ca878@linaro.org> Date: Mon, 12 Dec 2022 10:15:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> <77246ee3-8ff5-1049-6b2a-d8925bc87b33@linaro.org> From: Konrad Dybcio In-Reply-To: <77246ee3-8ff5-1049-6b2a-d8925bc87b33@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.12.2022 21:14, Krzysztof Kozlowski wrote: > On 10/12/2022 13:29, Konrad Dybcio wrote: >> >> >> On 10.12.2022 12:57, Krzysztof Kozlowski wrote: >>> The SoC node is a simple-bus and its schema expect to have nodes only >>> with unit addresses: >>> >>> sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': >>> ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} >>> >>> Move to top-level OPP tables: >>> - QUP which is shared between multiple nodes, >>> - QSPI which cannot be placed in its node due to address/size cells. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- >>> 1 file changed, 38 insertions(+), 38 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> index ea886cf08b4d..735581097295 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { >>> }; >>> }; >>> >>> + qspi_opp_table: opp-table-qspi { >>> + compatible = "operating-points-v2"; >>> + >>> + opp-75000000 { >>> + opp-hz = /bits/ 64 <75000000>; >>> + required-opps = <&rpmhpd_opp_low_svs>; >>> + }; >>> + >>> + opp-150000000 { >>> + opp-hz = /bits/ 64 <150000000>; >>> + required-opps = <&rpmhpd_opp_svs>; >>> + }; >>> + >>> + opp-300000000 { >>> + opp-hz = /bits/ 64 <300000000>; >>> + required-opps = <&rpmhpd_opp_nom>; >>> + }; >>> + }; >>> + >>> + qup_opp_table: opp-table-qup { >>> + compatible = "operating-points-v2"; >>> + >>> + opp-75000000 { >>> + opp-hz = /bits/ 64 <75000000>; >>> + required-opps = <&rpmhpd_opp_low_svs>; >>> + }; >>> + >>> + opp-100000000 { >>> + opp-hz = /bits/ 64 <100000000>; >>> + required-opps = <&rpmhpd_opp_svs>; >>> + }; >>> + >>> + opp-128000000 { >>> + opp-hz = /bits/ 64 <128000000>; >>> + required-opps = <&rpmhpd_opp_nom>; >>> + }; >>> + }; >>> + >>> memory@80000000 { >> Sidenote: memory@ should be moved above opp-*, alphabetically >> >> For this: >> >> Reviewed-by: Konrad Dybcio > > You sure? Because before there is already opp for cpu... Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes before 'o'. Konrad > > Best regards, > Krzysztof >