From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Date: Wed, 07 Dec 2016 20:15:32 +0100 Message-ID: <4532061.zEGHLIjg0t@phil> References: <1480645653-36943-1-git-send-email-briannorris@chromium.org> <1720836.rjtWqG8OD3@phil> <20161207174139.GA87970@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20161207174139.GA87970@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Brian Norris Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Caesar Wang , Doug Anderson , devicetree@vger.kernel.org, Rob Herring , Stephen Barber , linux-arm-kernel@lists.infradead.org, Chris Zhong List-Id: devicetree@vger.kernel.org Am Mittwoch, 7. Dezember 2016, 09:41:39 CET schrieb Brian Norris: > On Wed, Dec 07, 2016 at 06:12:13PM +0100, Heiko Stuebner wrote: > > Hi Brian, > > > > Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris: > > > Gru is a base dev board for a family of devices, including Kevin. Both > > > utilize Rockchip RK3399, and they share much of their design. > > > > > > Signed-off-by: Brian Norris > > > --- > > > > > > Documentation/devicetree/bindings/arm/rockchip.txt | 20 > > > > > > ++++++++++++++++++++ 1 file changed, 20 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > > > b/Documentation/devicetree/bindings/arm/rockchip.txt index > > > cc4ace6397ab..830e13f5890c 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings > > > > > > "google,veyron-speedy-rev3", "google,veyron-speedy-rev2", > > > "google,veyron-speedy", "google,veyron", "rockchip,rk3288"; > > > > > > +- Google Gru (dev-board): > > boards sorted alphabetically please > > > > Brian, Gru, Jaq, ... Kevin, ... > > > > While the sorting of old boards is not right yet, new boards should be > > sorted. > I got the idea that there was some attempt to group logically before > alphabetically. Like keeping board/SoC families together. But maybe not. > > I can do as you suggested, if you don't care about keeping actual > similar boards together (i.e., veyron/3288 vs gru/3399). I'd prefer a simple alphabetical sorting. I think people reading the document will know what device they have, but not necessarily the actual soc in it. At least I would look for Google Kevin primarily without thinking of the soc at first. And in general, most Rockchip boards (maybe except Google-boards) tend to follow the reference design quite closely, so it may become hard to decide when one is similar to another :-) . So best to keep it simple.