Re: [PATCH v3 3/4] usb: gadget: pxa27x_udc device-tree documentation

[Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>]

On Sunday 29 June 2014 16:01:12 Robert Jarzmik wrote:
> +Required properties:
> + - compatible: Should be "marvell,pxa270-udc" for USB controllers
> +   used in device mode.
> + - reg: usb device MMIO address space
> + - interrupts: single interrupt generated by the UDC IP
> + - clocks: input clock of the UDC IP (see clock-bindings.txt)
> +
> +Optional properties:
> + - gpios:
> +   - gpio activated to control the USB D+ pullup (see gpio.txt)
> +
> +Example:
> +
> +               pxa27x_udc: udc@40600000 {
> +                       compatible = "marvell,pxa270-udc";
> +                       reg = <0x40600000 0x10000>;
> +                       interrupts = <11>;
> +                       clocks = <&pxa2xx_clks 11>;
> +                       clock-names = "udc";
> +                       gpios = <&gpio 22 GPIO_ACTIVE_LOW>;
> +               };
> 

If you use a clock-names property, you have to list the required
clock names in the documentation above. Alternatively, just make
it an anonymous clock in the driver and change the example
to remove the clock-names.

IIRC there is a some confusion in the pxa/mmp USB drivers regarding
the clock names, and this has to be cleaned up in order to have proper
bindings.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html