From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34BA210A2A for ; Mon, 5 Feb 2024 07:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707119443; cv=none; b=PinDuXeVYipS/gJHL/EwNnJY6oNBZ1XYL2VLUgCGjkplLdNLHpoeILW5z5B0mFPP1a1XgJ/hH1dNGTQ7OyoQHP1AoM684BkQ1DcvcJCVFZc9FZj1tizYR/Jj8BGhgcXSPZA/VO6tI+CqvPeGWTW2dHiEmei2oAcEbt8s3AM2lVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707119443; c=relaxed/simple; bh=lwSrMmOjwPC91lnSiVSA3srT2ZRIN0dI4FdceHGIDQg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gta6EZdBUyz+hD1+CwmnKaLRLsJQ5+zWc1Rgmn1bejzwxgSl7El4xRj9eWhOQvnMcYn7vwkCfhiY0fgugc5d1OfZLuA6NpS5tzDw2CWrVAcSwMzK+6Fd5YK3WxKqgx0KZgUicsa5afk1kKv0B/CR+XJXqrGSdaGWrX9uOcLmiVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kFebaLoi; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kFebaLoi" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-55cca88b6a5so4792419a12.1 for ; Sun, 04 Feb 2024 23:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707119439; x=1707724239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zDNzB6806s+YPd0B8ZwsEbQr+QuziTaXidB2+L8zPzI=; b=kFebaLoiJr4Oql3y01DbMbVqtGkU+9pjA9yM0+ZvYdzXHrhx3TzD0xnJskATmMdi2K 8iRVkOkjEVzBFDQW6MFMfGCjjFQBCHYhAdIqDPmabtulXLcXnHLY8x9gr4ZJ7d9mHol2 D9j2rYTwoBB8SQBlPQzX6SHGxmqbNw/SJACLXyyu5NiXhnk1V7ZlFzIg+an99CgXYDT4 YvU11EClMg8SP+U7edKIt/4d9+2sOp4zZGm1/xdx9oUezSaKpaMcyu4VbQq+XFWLL5mg OFXO21cOPCt+Ye5rKrwM5zjBG84TMEgqFtSnxPt4nN9MA67GWavx1v5+CBPKl+eKQeOf vJ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707119439; x=1707724239; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zDNzB6806s+YPd0B8ZwsEbQr+QuziTaXidB2+L8zPzI=; b=em/OTvYBXZSkFIoWDWffsvXl+g4j7MXZ2tQ/FJY4LQaO425o7ifgEyfMM/NO1H4x/J lm4yXhwDPeOrMjJ4Z2Jsv5/nRfOm8Zv9cExhmo43Z/9uOOQEeo9OPwjWOCa46v/FltGk cmT699rzk1jokNBOtGFXOSXMNMFaTFX7Z7tHW9IdGbjiM7GD39jIHoiZQVRRa+F59WMB 79gFOf/UmzIIuxNIM7VkQYk0h3tyhyv6nj2eoj8a9qLNLFMKCu3Kry4wzM53oSQXThJl sSsPnNktsWmCzk+La+XqaAA2FzNk6HrQ0VmHxZ06a4tcdfi0gHpQzyAU2Fku8LHcKEQD r4hw== X-Gm-Message-State: AOJu0YxSxrN/UKHxJ2ix9pxLwTMDBa3EDTibMzfQEGAoJMRAaRjDh62j wiL8FLDu0cJfi5ZFIOZSjSPRhyc5Vd9gteW/seJ8J/yt6jMw1r2rIPxXV8hUVnM= X-Google-Smtp-Source: AGHT+IETFUwkrooLbqPV1xj26+22aHKZj+7oPOQZOa0xZ6l0cwfd4wsfFx3gdDkOduyP4fg+r5H+9Q== X-Received: by 2002:aa7:d58b:0:b0:55f:832f:97da with SMTP id r11-20020aa7d58b000000b0055f832f97damr4288530edq.23.1707119439428; Sun, 04 Feb 2024 23:50:39 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWGrFjitMKrsjm8vRNScZq1+w9A4UpzIq5DZK7ZRYUP1G2fwkiu3jyzQ8KN0tKdo99VGydvxDaBSfX3+SDvcTlmBvT7skZsZZIB2YzIvx661cRVB45QEidyRrDup1o2YQ5YIa+SOL9H40i7n5jvGRH7ExSEVrt8JuX3P5AEjMf7sIpAUpxAdQMl8qYMwuJPfbB9U8BYDTJR4Tj2kUKqUzIAWYiJRxFe/ZkVBIhpiqD99fcrxMwCCbcESgsjNLarfc0xwb3YF7iArL4c73bWgsYnNVo89+AFyJ+eY/OJn4Q5YjcgSNSOQ2jffFM7ckVRcWE/WbP7UJxNciDc5TcH91D+DnCtr0EvQ0mlqyTFdEd0wdGrizM/7kf+gZ6lkhFo9hcSSk/vTtLCSIfemoXb2vPHXZ1HjFqwspK0+yO41dtipRJr1mQ8g43ItcxlxeuR/A62nksvy5FXQfcAk1ONzJkGEDjjKsdDWc+R9LIc//g7EJv3 Received: from [192.168.1.20] ([178.197.222.62]) by smtp.gmail.com with ESMTPSA id i23-20020a056402055700b0055fba4996d9sm3610777edx.71.2024.02.04.23.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 23:50:38 -0800 (PST) Message-ID: <454616d4-19f6-408c-ba12-fa48cc04bce6@linaro.org> Date: Mon, 5 Feb 2024 08:50:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH v5 4/8] dt-bindings: usb: ci-hdrc-usb2: add restrictions for reg, interrupts, clock and clock-names properties Content-Language: en-US To: Xu Yang , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "peter.chen@kernel.org" Cc: dl-linux-imx , Jun Li , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20240131114324.3722428-1-xu.yang_2@nxp.com> <20240131114324.3722428-4-xu.yang_2@nxp.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/02/2024 07:56, Xu Yang wrote: > >> >> On 02/02/2024 10:10, Xu Yang wrote: >>> Hi Krzysztof, >>> >>>> >>>> On 31/01/2024 12:43, Xu Yang wrote: >>>>> Change reg, interrupts, clock and clock-names as common properties and add >>>>> restrictions on them for different compatibles. >>>>> >>>>> Signed-off-by: Xu Yang >>>>> >>>>> --- >>>>> Changes in v4: >>>>> - new patch since v3's discussion >>>>> - split the reg, interrupts, clock and clock-names properties into >>>>> common part and device-specific >>>>> Changes in v5: >>>>> - keep common property unchanged >>>>> - make if-then more readable >>>>> - remove non imx part >>>>> --- >>>>> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 118 ++++++++++++++++++ >>>>> 1 file changed, 118 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci- >>>> hdrc-usb2.yaml >>>>> index 3b56e0edb1c6..6ad3582051b8 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml >>>>> @@ -412,6 +412,124 @@ allOf: >>>>> samsung,picophy-pre-emp-curr-control: false >>>>> samsung,picophy-dc-vol-level-adjust: false >>>>> >>>>> + - if: >>>>> + properties: >>>>> + compatible: >>>>> + const: fsl,imx27-usb >>>>> + then: >>>>> + properties: >>>>> + clocks: >>>>> + minItems: 3 >>>>> + maxItems: 3 >>>>> + clock-names: >>>>> + minItems: 3 >>>>> + maxItems: 3 >>>>> + items: >>>>> + anyOf: >>>>> + - const: ipg >>>>> + - const: ahb >>>>> + - const: per >>>> >>>> This would be just: enum: [ipg, ahb, per], but in both cases I question >>>> why the order should be flexible? Nothing in commit msg explains it. >>> >>> The driver will get the clock by clock-name, then the order should not >>> matter. However, these three clock-names should be present at the same >>> time. I should use enum then. >> >> Forgot to answer to this. >> >> Which driver? U-boot? OpenBSD? The one in my custom Linux kernel fork >> (open-source and published on github)? Did you check all of them? > > I mean below driver in linux kernel tree. > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/tree/drivers/usb/chipidea/ci_hdrc_imx.c?h=linux-6.1.y#n191 What about others? How about driver in other upstream projects? My comment should make you think... Best regards, Krzysztof