devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: frank-w@public-files.de, robh+dt@kernel.org, matthias.bgg@gmail.com
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
	daniel@makrotopia.org, linux@fw-web.de, leith@bade.nz
Subject: Re: Aw: Re: Aw: [PATCH v3 1/2] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
Date: Wed, 27 Nov 2024 14:23:51 +0100	[thread overview]
Message-ID: <4549f33c-90d2-4b28-ab7a-1576c587c8cf@collabora.com> (raw)
In-Reply-To: <trinity-ef654aa8-f10a-4195-82c8-65b3ea654c7b-1730918975868@trinity-msg-rest-gmx-gmx-live-c75c5fb4b-p29nc>

Il 06/11/24 19:49, frank-w@public-files.de ha scritto:
> Hi
> 
> any new state on this??
> 
> https://patchwork.kernel.org/project/linux-mediatek/patch/20240608080530.9436-2-linux@fw-web.de/
> 
> regards Frank

I had a look at this one - and this is the situation:

  1. Your bootloader supports loading DTBO, so you can indeed use DTBOs
  2. Validation of the DTSO can still be done during kernel build without adding
     all of those possible X+Y+Z pre-joined DTBs
  3. What if your hardware had more than 20 possible configurations?
     Would you write 20 different Makefile entries? "sd+nand+nor",
     "sd+nand-withoutnor", "emmc+nand+nor", "emmc+nand-withoutnor",
     "emmc+sd+nor", "emmc+sd-withoutnor", "ufs+emmc", "ufs+emmc+sd",
     "ufs+sd+nor", "ufs+emmc-withoutnor", "ufs+sd-withoutnor", ......

Looks messy and unfeasible.

However, this is not a *global* no: I'm happy that your bootloader does support
loading DTBOs and, as far as I remember, even uses straps to vary the DTB(o) to
actually load - which is something proper and great... so it's a *no* for you,
but more than just a no, this is "why are you treating your proper bootflow
like it was a broken one?!?!" :-)

If anyone finds themselves in a situation in which there's no way to update a
bootloader (and that unfortunately happens more often than anyone would like
to see...) and in which the only way to apply DTBOs is to pre-overlay them
during the kernel build, then that's fine and I would (if nice and clean)
accept that.

But again, you're not in this kind of situation - and you're lucky that you're
dealing with a fully open device with a proper bootloader and bootflow: don't
ruin it like that!
Instead, if necessary, update the userspace tools that you're using to deal with
multiple DTBOs during system upgrades: that's the right thing to do at this point.

Cheers,
Angelo

  reply	other threads:[~2024-11-27 13:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-08  8:05 [PATCH v3 0/2] rework bpi-r3 dts overlays and add SATA dtso Frank Wunderlich
2024-06-08  8:05 ` [PATCH v3 1/2] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
2024-06-26 20:45   ` Aw: " Frank Wunderlich
2024-06-27 10:10     ` AngeloGioacchino Del Regno
2024-06-27 10:28       ` Frank Wunderlich
2024-07-03 23:34         ` Leith Bade
2024-11-06 18:49           ` Aw: " frank-w
2024-11-27 13:23             ` AngeloGioacchino Del Regno [this message]
2024-11-27 15:04               ` Aw: " frank-w
2024-06-08  8:05 ` [PATCH v3 2/2] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3 Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4549f33c-90d2-4b28-ab7a-1576c587c8cf@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frank-w@public-files.de \
    --cc=krzk+dt@kernel.org \
    --cc=leith@bade.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@fw-web.de \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).