From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8B3C4332F for ; Thu, 3 Nov 2022 13:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbiKCNGb (ORCPT ); Thu, 3 Nov 2022 09:06:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbiKCNFZ (ORCPT ); Thu, 3 Nov 2022 09:05:25 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C9FCEC for ; Thu, 3 Nov 2022 06:05:07 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id x18so1028392qki.4 for ; Thu, 03 Nov 2022 06:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tL7AwfEBawTS+joLBkklvfoShDprpUx2/6j95Zbc8aA=; b=HnM4RYT7W3UJ8p26skbBWk0h0ULoWqMqWPTxa7s6KvXlWtzVtn5eMbn5ecwVDZEO8E 73VYMQMsZSIf1tRTKGTvDMsQIbHkVFIHXA+g3TQfT+YpmG689c8lzb3HQq+iSiAw2ZLU hKXzH6ypb+WofX6cu6swXdZNQj6p3MmOjCI4zWslr/r7KYQ8VIpf9lHz7Lqbpqgz6d+j PSiXqwajYhapUCCW3HAznl4I/U05A6lc+VEXtX1pPZHq/jHCjLV8K83kXBvyA7mjkdQJ Xo/LqgU1hEglCsSAQKualA7z004wVa1lQM46/zEImGQ5uiui7Jmw7gaPZ4Sm0dRhkVtt mgiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tL7AwfEBawTS+joLBkklvfoShDprpUx2/6j95Zbc8aA=; b=VDnJ1j/7oLQDWVgn3na6BnxRPnt3t0aqUcZlYUG6uI69Bu7FAuzVmPJyy6/dEC+L0X DV/fguT1449GwWi9rzGaX14pcdS4XT7kcOYjA8fX26c5hBhbxSnF0iRjKxV2uN77na40 t7ths1epdZ0JGW4FYpF2VzwvoaPGU87KdpMNhFo4/iKGMYbmyvahV2Fowe85N9Lap9Xd RV42bnSTQoQJEksD1tbcil9QXDoxDoy/gC3nO6lyNfuRg9w5BSMPfddVTYUA7+NULvGU OfLqrH7xPJ+FmfzH6YNkyYuypGew94V5n1WeVPB9m7yl8nB4dxfLoPJHUdO71LWyc2Tc nzQA== X-Gm-Message-State: ACrzQf3/GK9EdCC13M3BvfoSuqGQfNAtj+k9OZc0gmoLxS3zoT1OKT1d 84yxNRYM1Yddk6T0oFy/iHLy2w== X-Google-Smtp-Source: AMsMyM5ZGsWmQM1YtOhYFTGB5v1V62Jt/nJDBwPcUsBnJdR4+gELIOCqHVcdrLhkBDWPPaakwcxv0g== X-Received: by 2002:a05:620a:4694:b0:6ee:b286:281a with SMTP id bq20-20020a05620a469400b006eeb286281amr21859211qkb.455.1667480706973; Thu, 03 Nov 2022 06:05:06 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id az40-20020a05620a172800b006ce7cd81359sm691741qkb.110.2022.11.03.06.05.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 06:05:06 -0700 (PDT) Message-ID: <4556aebd-1296-bb08-2cd7-3d92571ed71b@linaro.org> Date: Thu, 3 Nov 2022 09:05:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding Content-Language: en-US To: lee , linux-media@vger.kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, devicetree@vger.kernel.org References: <20221103110424.00007a48@arducam.com> From: Krzysztof Kozlowski In-Reply-To: <20221103110424.00007a48@arducam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/11/2022 23:04, lee wrote: > Add YAML device tree binding for IMX519 CMOS image sensor, and > the relevant MAINTAINERS entries. > > Signed-off-by: Lee Jackson Your From does not match fully SoB. > --- > .../bindings/media/i2c/sony,imx519.yaml | 107 ++++++++++++++++++ > MAINTAINERS | 9 ++ > 2 files changed, 116 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > new file mode 100644 > index 000000000000..9b6cda96f613 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Lee Jackson > + > +description: |- > + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor > + with an active array size of 4656H x 3496V. It is programmable through > + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. > + Image data is sent through MIPI CSI-2, which is configured as either 2 or > + 4 data lanes. > + > +properties: > + compatible: > + const: sony,imx519 > + > + reg: > + description: I2C device address Skip description. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + VDIG-supply: Use lower case names. > + description: > + Digital I/O voltage supply, 1.05 volts > + > + VANA-supply: > + description: > + Analog voltage supply, 2.8 volts > + > + VDDL-supply: > + description: > + Digital core voltage supply, 1.8 volts > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the xclr pin, if any. > + Must be released (set high) after all supplies and INCK are applied. > + > +port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: |- > + The driver only supports two-lane operation. Please describe the hardware, not driver. > + items: > + - const: 1 > + - const: 2 > + > + clock-noncontinuous: true > + link-frequencies: true I think these are coming from video-interfaces, so no need for them. > + > + required: > + - data-lanes > + - link-frequencies > + > +required: > + - compatible > + - reg > + - clocks > + - VANA-supply > + - VDIG-supply > + - VDDL-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + imx519: sensor@1a { > + compatible = "sony,imx519"; > + reg = <0x1a>; > + clocks = <&imx519_clk>; > + VANA-supply = <&imx519_vana>; /* 2.8v */ > + VDIG-supply = <&imx519_vdig>; /* 1.05v */ > + VDDL-supply = <&imx519_vddl>; /* 1.8v */ > + > + port { > + imx519_0: endpoint { > + remote-endpoint = <&csi1_ep>; > + data-lanes = <1 2>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <493500000>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index e04d944005ba..5a617ab8c9b2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19236,6 +19236,15 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > F: drivers/media/i2c/imx412.c > > +SONY IMX519 SENSOR DRIVER > +M: Arducam Kernel Maintenance > +M: Lee Jackson > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > +F: drivers/media/i2c/imx519.c The file does not exist, so path is not correct (yet). Add it in 2/2. Best regards, Krzysztof