From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1FD669D2F for ; Mon, 27 May 2024 08:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716799086; cv=none; b=Wq6phKMSOyOSbn+YdxFcv+jqRcKpkqO2YD7KQQEWVX1mu2hbeZYzU54w28TIXB5tXz1hIgMbzN4+v3Y2Q5q3ctHNLWfVroQS4uB+cP9/IJ8Tj+eVHv9nGpSnxBn55BIzx/fr9zrRLo4rCgtNLV80owzzWRR/YSwjB++pfAkPZHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716799086; c=relaxed/simple; bh=7yJQzgp3LG9+SqLWr6zTQsXw6qv741M/Rp6MjNbH1tc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nC9867a+hZQbqQWcwWS9IEUY97sUV3DKGH1FhLFUS2miJBAK7Ic7w0Md5NmQQOvjw4fEFbUZBo464jl8hsB7RyO9koP/6FspHkSY61XXh8t+zp7IjDa+egI/l4a2SDdjTjgF1hisZo4I1yJ9uFMKZk/6PAwGaTju20evwhpTAf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ygOrnlg/; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ygOrnlg/" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5751bcb3139so12555473a12.1 for ; Mon, 27 May 2024 01:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1716799083; x=1717403883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7yJQzgp3LG9+SqLWr6zTQsXw6qv741M/Rp6MjNbH1tc=; b=ygOrnlg/T+50NS9L89ky3Bw5jBJqx77BBWHt98h4qwwkEpr8fwK+hQqoIKEVnkDZ+b hnp2lnCeu8M67lv6XxKfnjPewWRjvLruDfYOPOvK7bbBkt9bKocWfTXpxdXFBvvU0EAt 1rRUicVXicHzf4CFc430InIrq/FUhyNRFChARQLcEMxuU9eGgydRhj9CLriz0JOGXzv9 xFUlesZmvkSPxZD2AO4V3sWc+W/hBcQtBt9739YDQqW0tCVY+1qazgAxsrSON7XMbXnb xztBVavKgfSdnanPSsMh3yDzraNsxOTGjStY/MeMFWIFU6bGl6YFcOAnRWnMqigGUhU2 99mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716799083; x=1717403883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7yJQzgp3LG9+SqLWr6zTQsXw6qv741M/Rp6MjNbH1tc=; b=o5MkfE4/AWyGMGbLQpfruj1ZR7fdVZEB2C2bbF5J2fe7TcFO9+/aEw/FA2YFeSmG93 P90bXiVeXrfHZCNXf0b6/sNORbgZRtjO8yxWVTDQiaun5pMFKQnA1hTZyana7LjZWm4V ZD59y5d3ffYHhjjwOwV7vs94TtsnAn1eNJuE6UwahJUqNj2lVCTgj1St59TUSUNWd1tT IeBERMRwDN4R2RqvrctsdI3SPgtCFxeN/aca66C3mlh0uhLbmF3vxPPoOzkGco0hL+gw NXlWdDCA5xmRfPGwBaLdYHxvX2sj4wdO2TwT0OeZmwKWhYK/bRxP2ZldPCT0zl9a3lQq Es1w== X-Forwarded-Encrypted: i=1; AJvYcCUGG7CArMrP1y6ymfyJ1l/A5wPwRnT2vz5FJDMpN4xR+eQ8kEGqmPiIvBsOPawqwn5dZjqd2DWVHYtH1rDVDqMV4BkTV9B3nfCzoQ== X-Gm-Message-State: AOJu0YzG5ldC9iJ02d69isOex+D9ngZeodDPINtmerQUliR7zQD03jzk ZUlv1CkSWm9oMDD95PgwN9AnAvJl7nSRp6r8V+7I5sadaRz8H2PySUnvYhXl9Xo= X-Google-Smtp-Source: AGHT+IH/iXqC+L+EflTfnXDHtTdQkCcD9jw5SHF9Siu1D6pQ5lqCI6PA/ta8ZY/9nEeZbep4X6uIoQ== X-Received: by 2002:a50:cb8c:0:b0:579:c4cd:735d with SMTP id 4fb4d7f45d1cf-579c4cd75d9mr2691205a12.11.1716799083189; Mon, 27 May 2024 01:38:03 -0700 (PDT) Received: from [192.168.1.70] ([84.102.31.61]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5785233bb04sm5483333a12.12.2024.05.27.01.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 01:38:02 -0700 (PDT) Message-ID: <455d12a8-fefe-4593-97a9-4cbdc81b61a7@baylibre.com> Date: Mon, 27 May 2024 10:38:00 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/6] Mediatek thermal sensor driver support for MT8186 and MT8188 To: "Russell King (Oracle)" , Nicolas Pitre Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Lezcano , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20240524-mtk-thermal-mt818x-dtsi-v5-0-56f8579820e7@baylibre.com> <238nnn48-0o7r-22q2-2rpo-s3n7n62pn2q4@onlyvoer.pbz> Content-Language: en-US From: Julien Panis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/24/24 19:19, Russell King (Oracle) wrote: > On Fri, May 24, 2024 at 01:04:38PM -0400, Nicolas Pitre wrote: >> On Fri, 24 May 2024, Julien Panis wrote: >> >>> [RFC] When PATCH 1/6 and 2/6 are squashed, checkpatch raises this WARNING: >>> "DT binding docs and includes should be a separate patch." That's why I >>> split them in this v5. The problem is that the driver can't be compiled >>> any more at PATCH 1/6. It needs PATCH 2/6 to be compiled. Should the >>> checkpatch warning be ignored here ? Should I finally squash PATCH 1/6 >>> and PATCH 2/6 ? >> IMHO it might be preferable to preserve successful compilation across >> bisection than to appeal to checkpatch in this case. > Or, patch 1 adds the new definitions, subsequent patches convert the > users, and the last patch removes the old, now unused, definitions. > Thanks for this suggestion. I'll do something like that in next version.