From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35BEA18DB37 for ; Fri, 19 Dec 2025 12:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148843; cv=none; b=WMinFBi0tI+UuhHipiJi5Wd8+mnEzMMhHRBivKnG2+ditVLCvINgvEE29qfiJMSSb5RvG3TcrKwvmlTbekn+QB6Q3bSWmcFavg5VD/bT0Iyw+ShOtcFMBA+gfJyZC0s/pLDfuN0DMyM8JI2yvk0CeTeDIMdb/b0OoZ2ZKBsMrCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148843; c=relaxed/simple; bh=A5GavDctwAB/XITHqdSkrfRmvaw70MYu4OaFJghrz8Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fesjz6Mr0AOyE9orF3eo8Pl+8qNQ5V/hRk2XsmGNrIPknjt1fTrwZPuniMrWZF4w4Auzj0eWruXzRmFtSRo+PMcWt+N8rHEgojSBwCE8i/B4u7GKX/8xuxypyzog2mDa4JU1AQ+8gCYyVd+DRJHr6tHtYlXvLYrv9gDGvtA+lq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lBZbUpuc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LGNg9A9A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lBZbUpuc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LGNg9A9A" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBS7xn3940629 for ; Fri, 19 Dec 2025 12:54:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uc0x8VaMjRUEZ4B+o1zl7TpXIPYi6c2EiV7fxfCNRW0=; b=lBZbUpuciYoS8I8l OxnIHhWGzNLoCNDn8ZfiwD7en+rVG6czJRRMktbpZEj4jAo4b7nhgKGE2kz606/s IDNDf0RjmImcm4EZAzYZ75K7vKe6PtGloW6N/jNXsPKAXXFi/L2Uwsgiq1IC+gay Jae1ptoUsZIaVNz9wQqK30OISy4JrXqsLjXd89KSt3sViyc+2m63q0CjvQMQQ63h Ij05fxDWJgaSqTGCGGs3Oeu2yjUlu72rn+pkVpOoBpOEkYwvWnFP+6EgXKUOYAJX sFps7F1xpA369kvGy6xHPwuo0m+V9YdGyCn2/cbFcFPFyk/6jYEDX4ayEhjRnQ2t pejJqw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2c2pkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 12:54:01 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ede0bd2154so4215451cf.1 for ; Fri, 19 Dec 2025 04:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766148840; x=1766753640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uc0x8VaMjRUEZ4B+o1zl7TpXIPYi6c2EiV7fxfCNRW0=; b=LGNg9A9ArcIPNNdKntV2uL5aXsRRccwIf4a5SxAcUmg4ipsXohraVtSHtQP6kZXWI3 Nm/UB/yY66e+xl5YLVfqYNL7LfcHv7SMaThID+tWpnntArhPBmpBpUdD+fmskun8lAhF 8R3w/MM9ujHXzk5wC5W3pRs0J6HTTDgLe/ZxrR2wAR5LpMtf4E7R4Lv2powFx0L5nWIY coAI9YlSaceHWb9Wox9JISIeWkokaUcRQW/hqH1ReI0W2jr+fMAQ37YqerP5hYCPQOD2 rAhPgOQ6qW5fLM3EbQsPxKlWBAMCnRZgw6L5lDN59VzjDvlxv3uiC6x9Rd2sMOf1/aAX mVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766148840; x=1766753640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uc0x8VaMjRUEZ4B+o1zl7TpXIPYi6c2EiV7fxfCNRW0=; b=V1h2NS5hcNlh+10dKlH7OCmLR1hzzOHvWZ/RrbaPg/TVfy71z+FojeeomLys8YJLP4 9PMAhTf0OUmMAb9wzsz2zSNmOXBLRyIyTxTVQbHb3FD+8XzWUCIl+tAAIsuqxekHcQaz WILQRryl8kE2AAPEkIFSnTZyvLsdF3ouCSHcJT0u/WsiCmK5GcvuM1NMzzy9RVjomi9g /1rCJVBvARdQH84pU1PhX+uQxdj9esuKUavbk1uTu4QHTdoVxGa8j7U7sljKudRfzpaE PRr9uWjNDiC29+nGlqV+l/kfs4O5MeBJ6vXHZHtjKUtnkoe0ED8MBlqwH8xl0R4QKXIc r/lA== X-Forwarded-Encrypted: i=1; AJvYcCXaAYm1NGetvaV0+/3/oSPZZ8v+NWd5DWF17e3X+tkiL+8abhGXAEfQrA1BPzTCUD3jRFkfOkkQWR0O@vger.kernel.org X-Gm-Message-State: AOJu0YzrGDViOYVMTJPeUadtiyeXiJITJyD4wm1x5eV6ErxZBHm0c42m ITIxv5uB7Mc92dC0764ujgr+1+pgFIscCkugg8aIuRH7MeV6ysO0EXu+uvzd6UuFw52EbZZNCn+ bs5EG6KtXrDyM0ohdeGqhCjYZiU3dfbILeGiotCIlMAYnwpVCAFkSso2dwxB/wGXY X-Gm-Gg: AY/fxX6fja16ea39WnFRwDawV04UneeWRg9OVxlHgYze83P/q63NqKPLqN+0TrJtBG7 y+tz9J/BDgJDWKxZOP3mhnZhcFjZv1jB+7mRPGvDl0qv0qshasz7jY0IafhwzfOzB0GS3TqNeSI 5WouD715SyS8X9JYGVr5AkG67FIzHjb0QNCSbXBWv1SyVpR0j5N4ffX/O8PvbtR2g9HSFs8qlCZ STS/8SdDF2QZvbx6HtEjp+21qlUKXuy2AQhldTCQ7C/kMHrHCkYeYqRTzi6RqBiddSXeJfwTWwz S/a7cKgSZW8MS1LfWgtpSjpal2vjBA/UmVKBuE3MsGHat2Ry+PINIPGqrPWp5wu3EhLtHHJaMzC aVx9qadpDN0ZfSP1Up85/KXR8YoO9S4aCCRwMmD9FoGHxM/Q95I/pW76VFZoye65Eog== X-Received: by 2002:ac8:7c52:0:b0:4f3:616f:150 with SMTP id d75a77b69052e-4f4abbdff03mr27396331cf.0.1766148840349; Fri, 19 Dec 2025 04:54:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IETJwazkVhVLNAOvDcL9re7kMjF36XivSzx/P+vqZuX1/+RnZc/020kDrJfnq9yqyv7Wk3hRg== X-Received: by 2002:ac8:7c52:0:b0:4f3:616f:150 with SMTP id d75a77b69052e-4f4abbdff03mr27396111cf.0.1766148839915; Fri, 19 Dec 2025 04:53:59 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b803d3cea32sm163553966b.34.2025.12.19.04.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 04:53:59 -0800 (PST) Message-ID: <455edd55-132d-423d-b0c0-afc7fa40aa30@oss.qualcomm.com> Date: Fri, 19 Dec 2025 13:53:57 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: x1e78100-t14s: Add audio playback over DisplayPort To: Krzysztof Kozlowski , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Abel Vesa References: <20251217120051.98198-3-krzysztof.kozlowski@oss.qualcomm.com> <20251217120051.98198-4-krzysztof.kozlowski@oss.qualcomm.com> <2d4953c6-184d-423b-80e9-871c6e00da35@oss.qualcomm.com> <564732e7-2c86-417d-8568-69f40ea7d4da@kernel.org> <47758ce9-5ec6-4ed6-9f84-13cbdd444d75@oss.qualcomm.com> <487ff592-e67c-41c8-a398-f79aa6e5f69c@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <487ff592-e67c-41c8-a398-f79aa6e5f69c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: zNb_8xyhmk1M0X8gcQJWWUGHbfeKXCCp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEwNiBTYWx0ZWRfX0HAjqarwWCSb XNnlTQGK+u7IuGWuusfHzIE7P8HoW3vKPvUveFVmc38t/vPttIiOSjZDLRNKH82oLiokwOOkQEO j6pj/2BrL7MV4hW6aT3mUdr2qstFypowBDxtYoIqibYaM6dfSEIqfM3w+WNyMyxtDZqf0pcsN3g FAo8gGrEfOV32XvpQfUbG67YdYzgQ+OCNwvb9h0H7cKSTjuu2/3c07jYY4GlUpQrgexWZ4pSC23 IUUiGnqHpYtdR3VoW3CFEnw6F5lc9RVTemNORrN8wnSQJp3zvCKOslqQ/kOw7KvbiWvkoLUlI5l 6k4ATAVCiajq07vCKECH39KA2txISOZyDW4mfzmrSD3nFHRGEeGKo1d/waLK9aHfXles7bL9gN7 0OHlFKmIcq6YiBs4bSMQvi9i4iePCsyeiV5fck/H1dlFIuOOHbXoYO1OxiG1oOKmhBNKMBI+cGj VIAYgebTqhg+INFrOsg== X-Authority-Analysis: v=2.4 cv=feSgCkQF c=1 sm=1 tr=0 ts=69454ae9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=vCpk0QvsQUMgD7SpnysA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: zNb_8xyhmk1M0X8gcQJWWUGHbfeKXCCp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_04,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190106 On 12/17/25 2:00 PM, Krzysztof Kozlowski wrote: > On 17/12/2025 13:51, Konrad Dybcio wrote: >> On 12/17/25 1:38 PM, Krzysztof Kozlowski wrote: >>> On 17/12/2025 13:33, Konrad Dybcio wrote: >>>> On 12/17/25 1:00 PM, Krzysztof Kozlowski wrote: >>>>> Add necessary DAI links and DAI name prefixes to enable audio playback >>>>> over USB/DisplayPort and HDMI. The HDMI port is not yet enabled, but it >>>>> should carry respective DAI name prefix regardless. >>>>> >>>>> Reviewed-by: Abel Vesa >>>>> Signed-off-by: Krzysztof Kozlowski >>>>> >>>>> --- >>>> >>>> (something's inserting a \n before --- in your latest patches but I >>> >>> No, it is not. It was always like that and only recently git started >>> dropping it, but it is irrelevant. >>> >>>> don't know if this is a problem) >>>> >>>> [...] >>>> >>>>> + displayport-2-dai-link { >>>>> + link-name = "DisplayPort2 Playback"; >>>>> + >>>>> + codec { >>>>> + sound-dai = <&mdss_dp2>; >>>> >>>> How does this work out with fw_devlink? >>> >>> How is this related to this patchset? Please stop nit-picking irrelevant >>> things. >> >> I'm asking whether this is going to break sync_state because you're not >> enabling mdss_dp2 - I believe that's a fair question.. > > DTS description is independent of driver, thus this is correct code > regardless whether there is interconnect involved anywhere or not. I > don't have the answer how this affects interconnect, but I see no reason > anyone would create such ICC path - between hardware and fake SW construct. sync_state isn't exclusive to the interconnect framework In any case, could you please confirm/deny that sound still works as expected with linux-next/master + this patch alone and we move on? Konrad